Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1689923002: Reland of Make cricket::VideoCapturer implement VideoSourceInterface (patchset #14 id:30000… (Closed)

Created:
4 years, 10 months ago by perkj_webrtc
Modified:
4 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

This reland https://codereview.webrtc.org/1655793003/ with the change that cricket::VideoCapturer::SignalVideoFrame is added back and used for frame forwarding. It is used in Chrome remoting. BUG=webrtc:5426 R=pthatcher@webrtc.org TBR=pthatcher@webrtc.org for moved channelmanager.... Committed: https://crrev.com/a50924115e47f052a61dc146e350b0677cd2ebd9 Cr-Commit-Position: refs/heads/master@{#11597}

Patch Set 1 : original landed patchset #

Patch Set 2 : Added SignalVideoFrame back #

Patch Set 3 : capturerenderadapter.h #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -343 lines) Patch
M webrtc/api/androidvideocapturer.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/api/remotevideocapturer_unittest.cc View 1 2 3 3 chunks +0 lines, -18 lines 0 comments Download
M webrtc/media/base/capturemanager.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/media/base/capturemanager.cc View 8 chunks +11 lines, -45 lines 0 comments Download
D webrtc/media/base/capturerenderadapter.h View 1 2 1 chunk +1 line, -48 lines 0 comments Download
M webrtc/media/base/capturerenderadapter.cc View 1 chunk +1 line, -73 lines 0 comments Download
M webrtc/media/base/fakevideorenderer.h View 3 chunks +6 lines, -0 lines 0 comments Download
M webrtc/media/base/videobroadcaster.h View 1 2 3 1 chunk +45 lines, -1 line 0 comments Download
M webrtc/media/base/videobroadcaster.cc View 1 2 3 1 chunk +69 lines, -1 line 0 comments Download
M webrtc/media/base/videocapturer.h View 1 8 chunks +27 lines, -13 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 2 3 5 chunks +28 lines, -12 lines 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 1 2 3 13 chunks +63 lines, -50 lines 0 comments Download
M webrtc/media/base/videoengine_unittest.h View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
M webrtc/media/base/videosinkinterface.h View 1 chunk +1 line, -2 lines 0 comments Download
A webrtc/media/base/videosourceinterface.h View 1 chunk +46 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.h View 1 2 3 3 chunks +8 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 1 2 3 5 chunks +7 lines, -12 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 2 3 5 chunks +7 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 2 3 11 chunks +20 lines, -28 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/pc/channelmanager.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/channelmanager.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
perkj_webrtc
Do you want to take a look at this change I had to do in ...
4 years, 10 months ago (2016-02-11 19:15:11 UTC) #4
pthatcher1
lgtm
4 years, 10 months ago (2016-02-11 19:22:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689923002/60001
4 years, 10 months ago (2016-02-12 09:08:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/5095) ios_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-12 09:09:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689923002/90023 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689923002/90023
4 years, 10 months ago (2016-02-12 10:33:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3406)
4 years, 10 months ago (2016-02-12 10:36:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689923002/90023 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689923002/90023
4 years, 10 months ago (2016-02-12 11:22:03 UTC) #18
perkj_webrtc
Committed patchset #4 (id:90023) manually as a50924115e47f052a61dc146e350b0677cd2ebd9 (presubmit successful).
4 years, 10 months ago (2016-02-12 12:31:14 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 12:31:15 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a50924115e47f052a61dc146e350b0677cd2ebd9
Cr-Commit-Position: refs/heads/master@{#11597}

Powered by Google App Engine
This is Rietveld 408576698