Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webrtc/call/call_perf_tests.cc

Issue 1689163002: removed five redundant avsync tests to make webrtc_perf_test faster (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call_perf_tests.cc
diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc
index f4422f4433ea48326ebb5ab4d93e22ccdd99189f..811aeca69bb780f259df8b078e6f28676a5bef3a 100644
--- a/webrtc/call/call_perf_tests.cc
+++ b/webrtc/call/call_perf_tests.cc
@@ -49,6 +49,9 @@ namespace webrtc {
class CallPerfTest : public test::CallTest {
protected:
+ static const bool kWithFEC = true;
+ static const bool kCreateAudioFirst = true;
+ static const bool kCreateVideoFirst = !kCreateAudioFirst;
void TestAudioVideoSync(bool fec,
pbos-webrtc 2016/02/15 09:52:28 Make this enum { kWithFec, kWithoutFec } FecMode;
danilchap 2016/02/15 10:03:59 Done.
bool create_audio_first,
pbos-webrtc 2016/02/15 09:52:28 enum StreamCreationOrder {kCreateAudioFirst, kCrea
danilchap 2016/02/15 10:03:59 Done.
float video_ntp_speed,
@@ -377,48 +380,22 @@ void CallPerfTest::TestAudioVideoSync(bool fec,
VoiceEngine::Delete(voice_engine);
}
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithAudioCreatedFirst) {
- TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
- DriftingClock::kNoDrift, DriftingClock::kNoDrift);
-}
-
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoCreatedFirst) {
- TestAudioVideoSync(false, false, DriftingClock::kNoDrift,
- DriftingClock::kNoDrift, DriftingClock::kNoDrift);
-}
-
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithFec) {
- TestAudioVideoSync(true, false, DriftingClock::kNoDrift,
- DriftingClock::kNoDrift, DriftingClock::kNoDrift);
-}
-
// TODO(danilchap): Reenable after adding support for frame capture clock
// that is not in sync with local TickTime clock.
TEST_F(CallPerfTest, DISABLED_PlaysOutAudioAndVideoInSyncWithVideoNtpDrift) {
- TestAudioVideoSync(false, true, DriftingClock::PercentsFaster(10.0f),
+ TestAudioVideoSync(!kWithFEC, kCreateAudioFirst,
+ DriftingClock::PercentsFaster(10.0f),
DriftingClock::kNoDrift, DriftingClock::kNoDrift);
}
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithAudioRtpDrift) {
- TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
- DriftingClock::kNoDrift,
- DriftingClock::PercentsFaster(30.0f));
-}
-
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoRtpDrift) {
- TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
- DriftingClock::PercentsFaster(30.0f),
- DriftingClock::kNoDrift);
-}
-
TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithAudioFasterThanVideoDrift) {
- TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
+ TestAudioVideoSync(!kWithFEC, kCreateAudioFirst, DriftingClock::kNoDrift,
DriftingClock::PercentsSlower(30.0f),
DriftingClock::PercentsFaster(30.0f));
}
TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoFasterThanAudioDrift) {
- TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
+ TestAudioVideoSync(kWithFEC, kCreateVideoFirst, DriftingClock::kNoDrift,
DriftingClock::PercentsFaster(30.0f),
DriftingClock::PercentsSlower(30.0f));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698