Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: webrtc/call/call_perf_tests.cc

Issue 1689163002: removed five redundant avsync tests to make webrtc_perf_test faster (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call_perf_tests.cc
diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc
index f4422f4433ea48326ebb5ab4d93e22ccdd99189f..24807c837187dd632b6146b75dfdd61911d8a4e0 100644
--- a/webrtc/call/call_perf_tests.cc
+++ b/webrtc/call/call_perf_tests.cc
@@ -377,17 +377,22 @@ void CallPerfTest::TestAudioVideoSync(bool fec,
VoiceEngine::Delete(voice_engine);
}
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithAudioCreatedFirst) {
+// TODO(danilchap): Enable this test for detailed AVSync troubleshooting.
+TEST_F(CallPerfTest,
+ DISABLED_PlaysOutAudioAndVideoInSyncWithAudioCreatedFirst) {
TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
DriftingClock::kNoDrift, DriftingClock::kNoDrift);
}
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoCreatedFirst) {
+// TODO(danilchap): Enable this test for detailed AVSync troubleshooting.
+TEST_F(CallPerfTest,
+ DISABLED_PlaysOutAudioAndVideoInSyncWithVideoCreatedFirst) {
TestAudioVideoSync(false, false, DriftingClock::kNoDrift,
DriftingClock::kNoDrift, DriftingClock::kNoDrift);
}
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithFec) {
+// TODO(danilchap): Enable this test for detailed AVSync troubleshooting.
+TEST_F(CallPerfTest, DISABLED_PlaysOutAudioAndVideoInSyncWithFec) {
TestAudioVideoSync(true, false, DriftingClock::kNoDrift,
DriftingClock::kNoDrift, DriftingClock::kNoDrift);
}
@@ -399,13 +404,15 @@ TEST_F(CallPerfTest, DISABLED_PlaysOutAudioAndVideoInSyncWithVideoNtpDrift) {
DriftingClock::kNoDrift, DriftingClock::kNoDrift);
}
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithAudioRtpDrift) {
+// TODO(danilchap): Enable this test for detailed AVSync troubleshooting.
+TEST_F(CallPerfTest, DISABLED_PlaysOutAudioAndVideoInSyncWithAudioRtpDrift) {
TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
DriftingClock::kNoDrift,
DriftingClock::PercentsFaster(30.0f));
}
-TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoRtpDrift) {
+// TODO(danilchap): Enable this test for detailed AVSync troubleshooting.
+TEST_F(CallPerfTest, DISABLED_PlaysOutAudioAndVideoInSyncWithVideoRtpDrift) {
TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
DriftingClock::PercentsFaster(30.0f),
DriftingClock::kNoDrift);
@@ -418,7 +425,7 @@ TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithAudioFasterThanVideoDrift) {
}
TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoFasterThanAudioDrift) {
- TestAudioVideoSync(false, true, DriftingClock::kNoDrift,
+ TestAudioVideoSync(true, false, DriftingClock::kNoDrift,
kwiberg-webrtc 2016/02/12 09:30:38 This change appears to be unrelated to the rest of
danilchap 2016/02/12 09:54:26 flags changed to cover situations that were covere
kwiberg-webrtc 2016/02/12 10:07:09 Oh, OK.
DriftingClock::PercentsFaster(30.0f),
DriftingClock::PercentsSlower(30.0f));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698