Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1689163002:
removed five redundant avsync tests to make webrtc_perf_test faster (Closed)
|
Created:
4 years, 10 months ago by danilchap Modified:
4 years, 10 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
Descriptionremoved five redundant avsync tests to make webrtc_perf_test faster
R=kwiberg@webrtc.org, pbos@webrtc.org
Committed: https://crrev.com/cde5d6b30562d8f1dfa01a0566b9630231c12001
Cr-Commit-Position: refs/heads/master@{#11620}
Patch Set 1 #Patch Set 2 : #
Total comments: 3
Patch Set 3 : #
Total comments: 2
Patch Set 4 : #
Total comments: 4
Patch Set 5 : retyped comments #Messages
Total messages: 17 (6 generated)
Description was changed from ========== removed two redundant tests to make webrtc_perf_test faster BUG= ========== to ========== disabled five redundant avsync tests to make webrtc_perf_test faster BUG= ==========
danilchap@webrtc.org changed reviewers: + kwiberg@webrtc.org, pbos@webrtc.org
lgtm, but see comment Also, remove the BUG= from the commit message if you don't fill it in. https://codereview.webrtc.org/1689163002/diff/20001/webrtc/call/call_perf_tes... File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/1689163002/diff/20001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:428: TestAudioVideoSync(true, false, DriftingClock::kNoDrift, This change appears to be unrelated to the rest of the CL?
Description was changed from ========== disabled five redundant avsync tests to make webrtc_perf_test faster BUG= ========== to ========== removed five redundant avsync tests to make webrtc_perf_test faster BUG= ==========
Description was changed from ========== removed five redundant avsync tests to make webrtc_perf_test faster BUG= ========== to ========== removed five redundant avsync tests to make webrtc_perf_test faster ==========
https://codereview.webrtc.org/1689163002/diff/20001/webrtc/call/call_perf_tes... File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/1689163002/diff/20001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:428: TestAudioVideoSync(true, false, DriftingClock::kNoDrift, On 2016/02/12 09:30:38, kwiberg-webrtc wrote: > This change appears to be unrelated to the rest of the CL? flags changed to cover situations that were covered by removed tests.
https://codereview.webrtc.org/1689163002/diff/20001/webrtc/call/call_perf_tes... File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/1689163002/diff/20001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:428: TestAudioVideoSync(true, false, DriftingClock::kNoDrift, On 2016/02/12 09:54:26, danilchap wrote: > On 2016/02/12 09:30:38, kwiberg-webrtc wrote: > > This change appears to be unrelated to the rest of the CL? > > flags changed to cover situations that were covered by removed tests. Oh, OK.
lgtm with comment added https://codereview.webrtc.org/1689163002/diff/40001/webrtc/call/call_perf_tes... File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/1689163002/diff/40001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:394: TestAudioVideoSync(true, false, DriftingClock::kNoDrift, Put a comment above this test and the one below to say that they are different in terms of what stream gets added first.
https://codereview.webrtc.org/1689163002/diff/40001/webrtc/call/call_perf_tes... File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/1689163002/diff/40001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:394: TestAudioVideoSync(true, false, DriftingClock::kNoDrift, On 2016/02/15 09:18:20, pbos-webrtc wrote: > Put a comment above this test and the one below to say that they are different > in terms of what stream gets added first. Proper code doesn't need comments Done with constants instead.
Agreed, but enforce it with types and not hairy constants https://codereview.webrtc.org/1689163002/diff/60001/webrtc/call/call_perf_tes... File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/1689163002/diff/60001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:55: void TestAudioVideoSync(bool fec, Make this enum { kWithFec, kWithoutFec } FecMode; https://codereview.webrtc.org/1689163002/diff/60001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:56: bool create_audio_first, enum StreamCreationOrder {kCreateAudioFirst, kCreateVideoFirst};
https://codereview.webrtc.org/1689163002/diff/60001/webrtc/call/call_perf_tes... File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/1689163002/diff/60001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:55: void TestAudioVideoSync(bool fec, On 2016/02/15 09:52:28, pbos-webrtc wrote: > Make this enum { kWithFec, kWithoutFec } FecMode; Done. https://codereview.webrtc.org/1689163002/diff/60001/webrtc/call/call_perf_tes... webrtc/call/call_perf_tests.cc:56: bool create_audio_first, On 2016/02/15 09:52:28, pbos-webrtc wrote: > enum StreamCreationOrder {kCreateAudioFirst, kCreateVideoFirst}; Done.
lgtm, thanks!
Description was changed from ========== removed five redundant avsync tests to make webrtc_perf_test faster ========== to ========== removed five redundant avsync tests to make webrtc_perf_test faster R=kwiberg@webrtc.org, pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/cde5d6b30562d8f1dfa01a056... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as cde5d6b30562d8f1dfa01a0566b9630231c12001 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== removed five redundant avsync tests to make webrtc_perf_test faster R=kwiberg@webrtc.org, pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/cde5d6b30562d8f1dfa01a056... ========== to ========== removed five redundant avsync tests to make webrtc_perf_test faster R=kwiberg@webrtc.org, pbos@webrtc.org Committed: https://crrev.com/cde5d6b30562d8f1dfa01a0566b9630231c12001 Cr-Commit-Position: refs/heads/master@{#11620} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/cde5d6b30562d8f1dfa01a0566b9630231c12001 Cr-Commit-Position: refs/heads/master@{#11620} |
