Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1688953003: Revert of Initial cleanup of cricket::VideoFrame. (Closed)

Created:
4 years, 10 months ago by nisse-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Initial cleanup of cricket::VideoFrame. (patchset #3 id:40001 of https://codereview.webrtc.org/1688643003/ ) Reason for revert: There appears there were some uses left of cricket::VideoFrame::GetRotation (to be replaced by GetVideoRotation). Investigating. Original issue's description: > Initial cleanup of cricket::VideoFrame. > > Deleted GetRotation (old alias for GetVideoRotation). > Deleted CopyToBuffer. > Deleted Sizeof. > Deleted Write. > Demote CopyToPlanes to protected status. > > BUG=webrtc:5426 TBR=perkj@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,pthatcher@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Committed: https://crrev.com/f9b59c4f30ca5c8802a793aa99aab6b63949a0f3 Cr-Commit-Position: refs/heads/master@{#11566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -19 lines) Patch
M webrtc/media/base/fakevideocapturer.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/base/videoframe.h View 3 chunks +35 lines, -12 lines 0 comments Download
M webrtc/media/base/videoframe.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 3 chunks +66 lines, -0 lines 0 comments Download
M webrtc/media/webrtc/webrtcvideoengine2_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/webrtc/webrtcvideoframe_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/media/webrtc/webrtcvideoframefactory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nisse-webrtc
Created Revert of Initial cleanup of cricket::VideoFrame.
4 years, 10 months ago (2016-02-11 09:38:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688953003/1
4 years, 10 months ago (2016-02-11 09:38:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 09:39:09 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:40:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9b59c4f30ca5c8802a793aa99aab6b63949a0f3
Cr-Commit-Position: refs/heads/master@{#11566}

Powered by Google App Engine
This is Rietveld 408576698