Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: webrtc/modules/pacing/bitrate_prober.h

Issue 1688703002: Prevent busy-looping PacedSender on small packets. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: remove packet_size_last_send_ = 0 and rename constant Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/pacing/bitrate_prober.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/pacing/bitrate_prober.h
diff --git a/webrtc/modules/pacing/bitrate_prober.h b/webrtc/modules/pacing/bitrate_prober.h
index b3f52afeb6ed4ed5d5bd983424c1bc3216794bca..84fbc522fc9e3b2e4d87d19dc53741c82a549367 100644
--- a/webrtc/modules/pacing/bitrate_prober.h
+++ b/webrtc/modules/pacing/bitrate_prober.h
@@ -31,8 +31,10 @@ class BitrateProber {
// TimeUntilNextProbe().
bool IsProbing() const;
- // Initializes a new probing session if the prober is allowed to probe.
- void MaybeInitializeProbe(int bitrate_bps);
+ // Initializes a new probing session if the prober is allowed to probe. Does
+ // not initialize the prober unless the packet size is large enough to probe
+ // with.
+ void OnIncomingPacket(int bitrate_bps, size_t packet_size, int64_t now_ms);
// Returns the number of milliseconds until the next packet should be sent to
// get accurate probing.
« no previous file with comments | « no previous file | webrtc/modules/pacing/bitrate_prober.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698