webrtc/media/engine/webrtcvideoengine2_unittest.cc - Issue 1688643003: Initial cleanup of cricket::VideoFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 1688643003: Initial cleanup of cricket::VideoFrame. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc

diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc

index c2293426891884d6006b0725c4e38718ea129880..b089d86ffaef7cf3662d20020d3591dd568e954e 100644

--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc

+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc

@@ -473,8 +473,8 @@ TEST_F(WebRtcVideoEngine2Test,

frame.width = 1280;

frame.height = 720;

frame.fourcc = cricket::FOURCC_I420;

- frame.data_size = static_cast<uint32_t>(

- cricket::VideoFrame::SizeOf(frame.width, frame.height));

+ frame.data_size = frame.width * frame.height +

+ 2 * ((frame.width + 1) / 2) * ((frame.height + 1) / 2);

rtc::scoped_ptr<char[]> data(new char[frame.data_size]);

frame.data = data.get();

memset(frame.data, 1, frame.data_size);