Implementing unified plan encoding of msid.

talk/app/webrtc/webrtcsdp.h

 /*
  * libjingle
  * Copyright 2011 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 32 matching lines @@
 
 class IceCandidateInterface;
 class JsepIceCandidate;
 class JsepSessionDescription;
 struct SdpParseError;
 
 // Serializes the passed in JsepSessionDescription.
 // Serialize SessionDescription including candidates if
 // JsepSessionDescription has candidates.
 // jdesc - The JsepSessionDescription object to be serialized.
+// unified_plan_sdp - If set to true, include "a=msid" lines where appropriate.
 // return - SDP string serialized from the arguments.
-std::string SdpSerialize(const JsepSessionDescription& jdesc);
+std::string SdpSerialize(const JsepSessionDescription& jdesc,
+                         bool unified_plan_sdp = false);

[pthatcher1, 2016/02/12 03:54:35]

Rather than have a default variable, can we make it explicit?  

In fact, it might even be nice to just have two functions:

SdpSerliazePlanB
SdpSerliazeUnifiedPlan

[Taylor Brandstetter, 2016/02/12 20:44:57]

Done.

 
 // Serializes the passed in IceCandidateInterface to a SDP string.
 // candidate - The candidate to be serialized.
 std::string SdpSerializeCandidate(const IceCandidateInterface& candidate);
 
 // Deserializes the passed in SDP string to a JsepSessionDescription.
 // message - SDP string to be Deserialized.
 // jdesc - The JsepSessionDescription deserialized from the SDP string.
 // error - The detail error information when parsing fails.
 // return - true on success, false on failure.
 bool SdpDeserialize(const std::string& message,
                     JsepSessionDescription* jdesc,
                     SdpParseError* error);
 
 // Deserializes the passed in SDP string to one JsepIceCandidate.
 // The first line must be a=candidate line and only the first line will be
 // parsed.
 // message - The SDP string to be Deserialized.
 // candidates - The JsepIceCandidate from the SDP string.
 // error - The detail error information when parsing fails.
 // return - true on success, false on failure.
 bool SdpDeserializeCandidate(const std::string& message,
                              JsepIceCandidate* candidate,
                              SdpParseError* error);
 }  // namespace webrtc
 
 #endif  // TALK_APP_WEBRTC_WEBRTCSDP_H_