Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 1687833006: rtc::Buffer: Replace an internal rtc::scoped_ptr with std::unique_ptr (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

rtc::Buffer: Replace an internal rtc::scoped_ptr with std::unique_ptr We'd like to completely replace rtc::scoped_ptr with std::unique_ptr. This is a first trial CL to see if using unique_ptr causes any problems. (As a side effect of removing the scoped_ptr.h include in buffer.h, I had to fix broken includes in no less than three files.) BUG=webrtc:5520 Committed: https://crrev.com/8fb355705211c60b7ea610eb0b69543dc5f7f8bf Cr-Commit-Position: refs/heads/master@{#11588}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M talk/app/webrtc/objc/RTCDataChannel.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/objc/RTCDataChannel.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/buffer.h View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-11 19:44:32 UTC) #6
pthatcher1
lgtm
4 years, 10 months ago (2016-02-11 19:56:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687833006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687833006/40001
4 years, 10 months ago (2016-02-11 21:28:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 10 months ago (2016-02-11 21:36:52 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 21:37:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fb355705211c60b7ea610eb0b69543dc5f7f8bf
Cr-Commit-Position: refs/heads/master@{#11588}

Powered by Google App Engine
This is Rietveld 408576698