Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1686323003: Use std::vector in the PayloadRouter interface. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use std::vector in the PayloadRouter interface. Prevents copying a vector to a list that gets copied back to a vector, which makes calling code a bit easier. BUG=webrtc:5494 R=danilchap@webrtc.org Committed: https://crrev.com/404686a3377bc74456a8e369426f0b1e39bafad7 Cr-Commit-Position: refs/heads/master@{#11589}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M webrtc/video/payload_router.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/payload_router.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M webrtc/video/vie_channel.cc View 4 chunks +5 lines, -10 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-11 16:14:06 UTC) #1
danilchap
https://codereview.webrtc.org/1686323003/diff/1/webrtc/video/vie_channel.cc File webrtc/video/vie_channel.cc (right): https://codereview.webrtc.org/1686323003/diff/1/webrtc/video/vie_channel.cc#newcode389 webrtc/video/vie_channel.cc:389: send_payload_router_->SetSendingRtpModules(registered_modules); why drop if(sender_) ?
4 years, 10 months ago (2016-02-11 16:22:07 UTC) #2
pbos-webrtc
https://codereview.webrtc.org/1686323003/diff/1/webrtc/video/vie_channel.cc File webrtc/video/vie_channel.cc (right): https://codereview.webrtc.org/1686323003/diff/1/webrtc/video/vie_channel.cc#newcode389 webrtc/video/vie_channel.cc:389: send_payload_router_->SetSendingRtpModules(registered_modules); On 2016/02/11 16:22:07, danilchap wrote: > why drop ...
4 years, 10 months ago (2016-02-11 16:38:32 UTC) #3
danilchap
On 2016/02/11 16:38:32, pbos-webrtc wrote: > https://codereview.webrtc.org/1686323003/diff/1/webrtc/video/vie_channel.cc > File webrtc/video/vie_channel.cc (right): > > https://codereview.webrtc.org/1686323003/diff/1/webrtc/video/vie_channel.cc#newcode389 > ...
4 years, 10 months ago (2016-02-11 16:40:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/404686a3377bc74456a8e369426f0b1e39bafad7 Cr-Commit-Position: refs/heads/master@{#11589}
4 years, 10 months ago (2016-02-11 22:37:41 UTC) #7
pbos-webrtc
4 years, 10 months ago (2016-02-11 22:37:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
404686a3377bc74456a8e369426f0b1e39bafad7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698