Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1685293002: Fix IntelligibilityEnhancerTest.TestRenderUpdate test (Closed)

Created:
4 years, 10 months ago by aluebs-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix IntelligibilityEnhancerTest.TestRenderUpdate test The crash was introduced in : https://codereview.webrtc.org/1672343002/. TBR=henrik.lundin@webrtc.org Committed: https://crrev.com/42d8aa77d867aa634b43ae9896a65b99139293f3 Cr-Commit-Position: refs/heads/master@{#11561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685293002/1
4 years, 10 months ago (2016-02-10 22:09:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 10 months ago (2016-02-11 00:10:18 UTC) #6
aluebs-webrtc
Committed patchset #1 (id:1) manually as 42d8aa77d867aa634b43ae9896a65b99139293f3 (presubmit successful).
4 years, 10 months ago (2016-02-11 00:10:41 UTC) #8
hlundin-webrtc
LGTM, but a BUG= wouldn't have gone amiss...
4 years, 10 months ago (2016-02-11 07:23:40 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42d8aa77d867aa634b43ae9896a65b99139293f3 Cr-Commit-Position: refs/heads/master@{#11561}
4 years, 10 months ago (2016-02-11 10:40:45 UTC) #11
aluebs-webrtc
On 2016/02/11 07:23:40, hlundin-webrtc wrote: > LGTM, but a BUG= wouldn't have gone amiss... That ...
4 years, 10 months ago (2016-02-11 17:28:02 UTC) #12
hlundin-webrtc
4 years, 10 months ago (2016-02-15 13:06:21 UTC) #14
Message was sent while issue was closed. 
On 2016/02/11 17:28:02, aluebs-webrtc wrote:
> On 2016/02/11 07:23:40, hlundin-webrtc wrote:
> > LGTM, but a BUG= wouldn't have gone amiss...
> 
> That is a good point, but a bug was never filed. The crash was introduced by
> https://codereview.webrtc.org/1672343002/ and I still dont know how it passed
> the CQ.
> I modified the description of this CL to add that.

Sorry. I initially thought this CL was for the UBSan fixes, but that was not the
case.

Powered by Google App Engine
This is Rietveld 408576698