Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: webrtc/api/test/fakevideotrackrenderer.h

Issue 1684423002: Make VideoTrack and VideoTrackRenderers implement rtc::VideoSourceInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase on master, copy VideoSourceInterface. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/test/fakevideotrackrenderer.h
diff --git a/webrtc/api/test/fakevideotrackrenderer.h b/webrtc/api/test/fakevideotrackrenderer.h
index 816b44744fc2acc35e6d9e62119fab5702331552..bbd6b55c52eff5025e7ee0c89c570727df2e53f5 100644
--- a/webrtc/api/test/fakevideotrackrenderer.h
+++ b/webrtc/api/test/fakevideotrackrenderer.h
@@ -16,19 +16,20 @@
namespace webrtc {
-class FakeVideoTrackRenderer : public VideoRendererInterface {
+class FakeVideoTrackRenderer
+ : public rtc::VideoSinkInterface<cricket::VideoFrame> {
perkj_webrtc 2016/02/12 14:40:14 Se should continue testing both until all clients
nisse-webrtc 2016/02/15 08:54:48 Unclear what you suggest... I think it should be
perkj_webrtc 2016/02/15 12:36:27 Sorry- I meant that currently clients such as chro
nisse-webrtc 2016/02/15 14:51:53 Made two variants of the VideoTrack.RenderVideo te
public:
FakeVideoTrackRenderer(VideoTrackInterface* video_track)
: video_track_(video_track), last_frame_(NULL) {
- video_track_->AddRenderer(this);
+ video_track_->AddOrUpdateSink(this, rtc::VideoSinkWants());
}
~FakeVideoTrackRenderer() {
- video_track_->RemoveRenderer(this);
+ video_track_->RemoveSink(this);
}
- virtual void RenderFrame(const cricket::VideoFrame* video_frame) override {
- last_frame_ = const_cast<cricket::VideoFrame*>(video_frame);
- fake_renderer_.RenderFrame(video_frame);
+ virtual void OnFrame(const cricket::VideoFrame& video_frame) override {
+ last_frame_ = const_cast<cricket::VideoFrame*>(&video_frame);
+ fake_renderer_.RenderFrame(&video_frame);
}
int errors() const { return fake_renderer_.errors(); }

Powered by Google App Engine
This is Rietveld 408576698