Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: webrtc/api/mediastreaminterface.h

Issue 1684423002: Make VideoTrack and VideoTrackRenderers implement rtc::VideoSourceInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Delete unused last_frame method and corresponding member. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/mediastreamtrackproxy.h » ('j') | webrtc/api/test/fakevideotrackrenderer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/mediastreaminterface.h
diff --git a/webrtc/api/mediastreaminterface.h b/webrtc/api/mediastreaminterface.h
index d4fe2bf0eb228f0a3323d9f2742faf2ea2fd388b..100db08d04aa4656330dc69fca8f7f1ea6f58991 100644
--- a/webrtc/api/mediastreaminterface.h
+++ b/webrtc/api/mediastreaminterface.h
@@ -24,6 +24,7 @@
#include "webrtc/base/refcount.h"
#include "webrtc/base/scoped_ref_ptr.h"
#include "webrtc/media/base/videosinkinterface.h"
+#include "webrtc/media/base/videosourceinterface.h"
namespace cricket {
@@ -121,12 +122,30 @@ class VideoRendererInterface
class VideoSourceInterface;
-class VideoTrackInterface : public MediaStreamTrackInterface {
+class VideoTrackInterface
+ : public MediaStreamTrackInterface,
+ public rtc::VideoSourceInterface<cricket::VideoFrame> {
public:
- // Register a renderer that will render all frames received on this track.
- virtual void AddRenderer(VideoRendererInterface* renderer) = 0;
- // Deregister a renderer.
- virtual void RemoveRenderer(VideoRendererInterface* renderer) = 0;
+ // Make an unqualified VideoSourceInterface resolve to
+ // webrtc::VideoSourceInterface, not our base class
+ // rtc::VideoSourceInterface<cricket::VideoFrame>.
+ using VideoSourceInterface = webrtc::VideoSourceInterface;
+
+ // AddRenderer and RemoveRenderer are for backwards compatibility
+ // only. They are obsoleted by the methods of
+ // rtc::VideoSourceInterface.
+ virtual void AddRenderer(VideoRendererInterface* renderer) {
+ AddOrUpdateSink(renderer, rtc::VideoSinkWants());
+ }
+ virtual void RemoveRenderer(VideoRendererInterface* renderer) {
+ RemoveSink(renderer);
+ }
+
+ // Register a video sink for this track.
+ void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
+ const rtc::VideoSinkWants& wants) override{};
+ void RemoveSink(
+ rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override{};
virtual VideoSourceInterface* GetSource() const = 0;
« no previous file with comments | « no previous file | webrtc/api/mediastreamtrackproxy.h » ('j') | webrtc/api/test/fakevideotrackrenderer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698