Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: webrtc/api/videotrackrenderers.cc

Issue 1684423002: Make VideoTrack and VideoTrackRenderers implement rtc::VideoSourceInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/api/videotrack.h ('K') | « webrtc/api/videotrackrenderers.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/videotrackrenderers.cc
diff --git a/webrtc/api/videotrackrenderers.cc b/webrtc/api/videotrackrenderers.cc
index a76becdbfa3488b090e98636817a7b347c69d178..026260a6238caf9559873be88bc486f628b1be55 100644
--- a/webrtc/api/videotrackrenderers.cc
+++ b/webrtc/api/videotrackrenderers.cc
@@ -19,17 +19,17 @@ VideoTrackRenderers::VideoTrackRenderers() : enabled_(true) {
VideoTrackRenderers::~VideoTrackRenderers() {
}
-void VideoTrackRenderers::AddRenderer(VideoRendererInterface* renderer) {
- if (!renderer) {
- return;
- }
+void VideoTrackRenderers::AddOrUpdateSink(
+ VideoSinkInterface<cricket::VideoFrame>* sink,
+ const rtc::VideoSinkWants& wants) {
rtc::CritScope cs(&critical_section_);
- renderers_.insert(renderer);
+ broadcaster_.AddOrUpdateSink(sink, wants);
perkj_webrtc 2016/02/11 15:30:44 broadcaster_ is single threaded. I am afraid remot
nisse-webrtc 2016/02/12 08:36:03 Ok, I'm going back to not using VideoBroadcaster.
}
-void VideoTrackRenderers::RemoveRenderer(VideoRendererInterface* renderer) {
+void VideoTrackRenderers::RemoveSink(
+ VideoSinkInterface<cricket::VideoFrame>* sink) {
rtc::CritScope cs(&critical_section_);
- renderers_.erase(renderer);
+ broadcaster_.RemoveSink(sink);
}
void VideoTrackRenderers::SetEnabled(bool enable) {
@@ -41,7 +41,7 @@ bool VideoTrackRenderers::RenderFrame(const cricket::VideoFrame* frame) {
{
rtc::CritScope cs(&critical_section_);
if (enabled_) {
- RenderFrameToRenderers(frame);
+ broadcaster_.OnFrame(*frame);
return true;
}
}
@@ -64,18 +64,10 @@ bool VideoTrackRenderers::RenderFrame(const cricket::VideoFrame* frame) {
// enabled while we generated the black frame. I think the
// enabled-ness ought to be applied at the track output, and hence
// an enabled track shouldn't send any blacked out frames.
- RenderFrameToRenderers(enabled_ ? frame : &black);
+ broadcaster_.OnFrame(enabled_ ? *frame : black);
return true;
}
}
-// Called with critical_section_ already locked
-void VideoTrackRenderers::RenderFrameToRenderers(
- const cricket::VideoFrame* frame) {
- for (VideoRendererInterface* renderer : renderers_) {
- renderer->RenderFrame(frame);
- }
-}
-
} // namespace webrtc
« webrtc/api/videotrack.h ('K') | « webrtc/api/videotrackrenderers.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698