Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: webrtc/api/videotrack.h

Issue 1684423002: Make VideoTrack and VideoTrackRenderers implement rtc::VideoSourceInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_API_VIDEOTRACK_H_ 11 #ifndef WEBRTC_API_VIDEOTRACK_H_
12 #define WEBRTC_API_VIDEOTRACK_H_ 12 #define WEBRTC_API_VIDEOTRACK_H_
13 13
14 #include <string> 14 #include <string>
15 15
16 #include "webrtc/api/mediastreamtrack.h" 16 #include "webrtc/api/mediastreamtrack.h"
17 #include "webrtc/api/videosourceinterface.h" 17 #include "webrtc/api/videosourceinterface.h"
18 #include "webrtc/api/videotrackrenderers.h" 18 #include "webrtc/api/videotrackrenderers.h"
19 #include "webrtc/base/scoped_ref_ptr.h" 19 #include "webrtc/base/scoped_ref_ptr.h"
20 20
21 namespace webrtc { 21 namespace webrtc {
22 22
23 class VideoTrack : public MediaStreamTrack<VideoTrackInterface> { 23 class VideoTrack : public MediaStreamTrack<VideoTrackInterface> {
24 public: 24 public:
25 static rtc::scoped_refptr<VideoTrack> Create( 25 static rtc::scoped_refptr<VideoTrack> Create(
26 const std::string& label, VideoSourceInterface* source); 26 // TODO(nisse): Why do we need the webrtc:: qualification on
27 // VideoSourceInterface???
perkj_webrtc 2016/02/11 15:30:43 I think you can use using=webrtc::VideoSourceInter
nisse-webrtc 2016/02/12 08:36:03 You mean using VideoSourceInterface = webrtc::V
28 const std::string& label,
29 webrtc::VideoSourceInterface* source);
27 30
28 virtual void AddRenderer(VideoRendererInterface* renderer); 31 void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
29 virtual void RemoveRenderer(VideoRendererInterface* renderer); 32 const rtc::VideoSinkWants& wants) override;
30 virtual VideoSourceInterface* GetSource() const { 33 void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;
34
35 virtual webrtc::VideoSourceInterface* GetSource() const {
31 return video_source_.get(); 36 return video_source_.get();
32 } 37 }
33 rtc::VideoSinkInterface<cricket::VideoFrame>* GetSink() override; 38 rtc::VideoSinkInterface<cricket::VideoFrame>* GetSink() override;
34 virtual bool set_enabled(bool enable); 39 virtual bool set_enabled(bool enable);
35 virtual std::string kind() const; 40 virtual std::string kind() const;
36 41
37 protected: 42 protected:
38 VideoTrack(const std::string& id, VideoSourceInterface* video_source); 43 VideoTrack(const std::string& id, webrtc::VideoSourceInterface* video_source);
39 ~VideoTrack(); 44 ~VideoTrack();
40 45
41 private: 46 private:
42 VideoTrackRenderers renderers_; 47 VideoTrackRenderers renderers_;
43 rtc::scoped_refptr<VideoSourceInterface> video_source_; 48 // TODO(nisse): And here.
perkj_webrtc 2016/02/11 15:30:44 dito
49 rtc::scoped_refptr<webrtc::VideoSourceInterface> video_source_;
44 }; 50 };
45 51
46 } // namespace webrtc 52 } // namespace webrtc
47 53
48 #endif // WEBRTC_API_VIDEOTRACK_H_ 54 #endif // WEBRTC_API_VIDEOTRACK_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698