Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1684403002: Android: Remove VideoCapturer (Closed)

Created:
4 years, 10 months ago by magjed_webrtc
Modified:
4 years, 6 months ago
Reviewers:
jojo9913, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, nisse-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Remove VideoCapturer This CL makes PeerConnectionFactory.createVideoSource() and nativeCreateVideoSource work directly with VideoCapturerAndroid instead of going via VideoCapturer. The native part is now created in nativeCreateVideoSource() instead of doing it immediately in VideoCapturerAndroid.create(). BUG=webrtc:5519 R=perkj@webrtc.org Committed: https://crrev.com/09eab315fddc3432c19d8f662f4b9360f2a58010 Cr-Commit-Position: refs/heads/master@{#11582}

Patch Set 1 #

Patch Set 2 : Nuke VideoCapturer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -108 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 9 chunks +12 lines, -21 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 1 5 chunks +5 lines, -19 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java View 1 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/VideoCapturer.java View 1 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
magjed_webrtc
perkj - Please take a look.
4 years, 10 months ago (2016-02-11 14:54:46 UTC) #4
perkj_webrtc
lgtm if you remove VideoCapturer completely.
4 years, 10 months ago (2016-02-11 15:14:09 UTC) #5
magjed_webrtc
On 2016/02/11 15:14:09, perkj_webrtc wrote: > lgtm if you remove VideoCapturer completely. done
4 years, 10 months ago (2016-02-11 15:16:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684403002/20001
4 years, 10 months ago (2016-02-11 15:17:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 10 months ago (2016-02-11 17:17:33 UTC) #12
magjed_webrtc
Committed patchset #2 (id:20001) manually as 09eab315fddc3432c19d8f662f4b9360f2a58010 (presubmit successful).
4 years, 10 months ago (2016-02-11 17:25:30 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/09eab315fddc3432c19d8f662f4b9360f2a58010 Cr-Commit-Position: refs/heads/master@{#11582}
4 years, 10 months ago (2016-02-11 17:25:42 UTC) #16
kjellander_webrtc
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.webrtc.org/1690073002/ by kjellander@webrtc.org. ...
4 years, 10 months ago (2016-02-11 20:21:36 UTC) #17
jojo9913
4 years, 6 months ago (2016-06-20 09:17:47 UTC) #20
jojo9913
On 2016/06/20 09:17:47, jojo9913 wrote: Remove video captured compleatly
4 years, 6 months ago (2016-06-20 09:22:15 UTC) #21
jojo9913
On 2016/06/20 09:22:15, jojo9913 wrote: > On 2016/06/20 09:17:47, jojo9913 wrote: > > Remove video ...
4 years, 6 months ago (2016-06-20 09:26:22 UTC) #22
jojo9913
4 years, 6 months ago (2016-06-20 09:49:20 UTC) #23
Message was sent while issue was closed.
Remove video capture immediatly

Powered by Google App Engine
This is Rietveld 408576698