Implement certificate lifetime parameter as required by WebRTC RFC.

webrtc/base/sslidentity.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 141 matching lines @@
   std::for_each(certs_.begin(), certs_.end(), DeleteCert);
 }
 
 #if SSL_USE_OPENSSL
 
 SSLCertificate* SSLCertificate::FromPEMString(const std::string& pem_string) {
   return OpenSSLCertificate::FromPEMString(pem_string);
 }
 
 SSLIdentity* SSLIdentity::Generate(const std::string& common_name,
-                                   const KeyParams& key_params) {
-  return OpenSSLIdentity::Generate(common_name, key_params);
+                                   const KeyParams& key_params,
+                                   time_t certificate_lifetime) {
+  return OpenSSLIdentity::Generate(common_name, key_params,

[hbos, 2016/02/12 11:40:12]

I think DCHECKing that |certificate_lifetime| is non-negative makes sense here.

[torbjorng (webrtc), 2016/02/12 12:58:00]

Which means test code cannot generate an expired certificate except by using
GenerateForTest() which you agreed should go away.

+                                   certificate_lifetime);
 }
 
 SSLIdentity* SSLIdentity::GenerateForTest(const SSLIdentityParams& params) {
   return OpenSSLIdentity::GenerateForTest(params);
 }
 
 SSLIdentity* SSLIdentity::FromPEMStrings(const std::string& private_key,
                                          const std::string& certificate) {
   return OpenSSLIdentity::FromPEMStrings(private_key, certificate);
 }
@@ skipping 68 matching lines @@
 
   if (bytes_left != 1) {
     // Now just Z should remain.  Its existence was asserted above.
     return -1;
   }
 
   return TmToSeconds(tm);
 }
 
 }  // namespace rtc