Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1683163002: Rename libjingle_media_unittest -> rtc_media_unittests (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename libjingle_media_unittest -> rtc_media_unittests Landing this must be coordinated with updating the buildbots in https://codereview.chromium.org/1681393004 R=pthatcher@webrtc.org TBR=henrika@webrtc.org BUG=webrtc:5420 NOTRY=True Committed: https://crrev.com/efce73e4ed1c832867e43d2f31103bcb5fc60027 Cr-Commit-Position: refs/heads/master@{#11600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
D webrtc/libjingle_media_unittest.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
M webrtc/media/media_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/rtc_media_unittests.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kjellander_webrtc
There's no point in running trybots that execute tests for this one, since the buildbot ...
4 years, 10 months ago (2016-02-10 16:37:06 UTC) #3
pthatcher1
lgtm
4 years, 10 months ago (2016-02-10 19:11:39 UTC) #5
kjellander_webrtc
+henrika for root owner (not really sure why needed but don't have time to investigate ...
4 years, 10 months ago (2016-02-12 14:05:53 UTC) #10
kjellander_webrtc
Committed patchset #1 (id:1) manually as efce73e4ed1c832867e43d2f31103bcb5fc60027 (presubmit successful).
4 years, 10 months ago (2016-02-12 14:06:16 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/efce73e4ed1c832867e43d2f31103bcb5fc60027 Cr-Commit-Position: refs/heads/master@{#11600}
4 years, 10 months ago (2016-02-12 14:06:21 UTC) #14
henrika_webrtc
4 years, 10 months ago (2016-02-12 14:06:45 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698