PRESUBMIT: Add check for JSON parse errors + fix JSON

PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True

Committed: https://crrev.com/569cf942c01ac08e755cac211bbfd4d93228aeea
Cr-Commit-Position: refs/heads/master@{#11572}

[kjellander_webrtc, 2016-02-10 13:34:50]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-02-10 13:35:33]

Description was changed from

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
==========

to

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
==========

[kjellander_webrtc, 2016-02-10 13:35:33]

kjellander@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[kjellander_webrtc, 2016-02-10 13:35:44]

Description was changed from

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
==========

to

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True
==========

[phoglund, 2016-02-11 08:38:56]

https://codereview.webrtc.org/1682393002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1682393002/diff/20001/PRESUBMIT.py#newcode353
PRESUBMIT.py:353: actions = {
Is this a pattern generally followed by all presubmits? It seems like
overengineering otherwise. You could just filter on extension in the for loop
and call _GetJsonParseError directly from there.

[kjellander_webrtc, 2016-02-11 09:23:28]

Patchset #2 (id:40001) has been deleted

[kjellander_webrtc, 2016-02-11 09:24:15]

PTAL

https://codereview.webrtc.org/1682393002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1682393002/diff/20001/PRESUBMIT.py#newcode353
PRESUBMIT.py:353: actions = {
On 2016/02/11 08:38:56, phoglund wrote:
> Is this a pattern generally followed by all presubmits? It seems like
> overengineering otherwise. You could just filter on extension in the for loop
> and call _GetJsonParseError directly from there.

Chromium has IDL files as well
(https://code.google.com/p/chromium/codesearch#chromium/src/PRESUBMIT.py&l=1269)
but I only wanted JSON for now. I simplified it now since it's unlikely we'll
need IDL.

[phoglund, 2016-02-11 12:43:08]

lgtm

[kjellander_webrtc, 2016-02-11 13:00:50]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-02-11 13:01:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682393002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682393002/60001

[commit-bot: I haz the power, 2016-02-11 13:03:01]

Description was changed from

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True
==========

to

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True
==========

[commit-bot: I haz the power, 2016-02-11 13:03:02]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-02-11 13:03:12]

Description was changed from

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True
==========

to

==========
PRESUBMIT: Add check for JSON parse errors + fix JSON

The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.

BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True

Committed: https://crrev.com/569cf942c01ac08e755cac211bbfd4d93228aeea
Cr-Commit-Position: refs/heads/master@{#11572}
==========

[commit-bot: I haz the power, 2016-02-11 13:03:13]

Patchset 2 (id:??) landed as
https://crrev.com/569cf942c01ac08e755cac211bbfd4d93228aeea
Cr-Commit-Position: refs/heads/master@{#11572}