Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1681493002: Fix GYP and GN references that are invalid in Chromium builds. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
hjon_webrtc, hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix GYP and GN references that are invalid in Chromium builds. There were a couple of GN and GYP references that were incorrect in Chromium builds: - GN references between WebRTC targets must be using relative paths, not absolute. - GYP references between WebRTC targets must be using the <(webrtc_root)v variable in order to be expanded to the correct path in a Chromium build. NOTRY=True TBR=hjon@webrtc.org, hbos@webrtc.org Committed: https://crrev.com/f6b55092295412a5cf1ffc7e77de0575eaca43b3 Cr-Commit-Position: refs/heads/master@{#11521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M talk/build/merge_ios_libs.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/test.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_webrtc
I guess I should write PRESUBMIT checks for these oddities and/or get trybot coverage for ...
4 years, 10 months ago (2016-02-08 06:58:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681493002/1
4 years, 10 months ago (2016-02-08 07:03:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 07:04:30 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 07:04:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6b55092295412a5cf1ffc7e77de0575eaca43b3
Cr-Commit-Position: refs/heads/master@{#11521}

Powered by Google App Engine
This is Rietveld 408576698