Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1681023003: Revert of Analyze support in gyp_webrtc (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Analyze support in gyp_webrtc (patchset #1 id:1 of https://codereview.webrtc.org/1369683004/ ) Reason for revert: I've decided to not aim for implementing analyze and focus on getting Swarming done instead, so I'm cleaning this up. Original issue's description: > Analyze support in gyp_webrtc > > BUG=chromium:482463 > TESTED=Manually tested using the JSON files attached to https://code.google.com/p/chromium/issues/detail?id=482463#c2 and: > webrtc/build/gyp_webrtc --analyzer nothing-files.json nothing-files-RESULT.json > webrtc/build/gyp_webrtc --analyzer everything-files.json everything-files-RESULT.json > webrtc/build/gyp_webrtc --analyzer test_support_unittests-files.json test_support_unittests-files-RESULT.json > Then I verified the result-json contained the expected output. > > R=phoglund@webrtc.org > > Committed: https://crrev.com/8108764552e20d657c0a6f75a6200b93de486659 > Cr-Commit-Position: refs/heads/master@{#10097} TBR=phoglund@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:482463 Committed: https://crrev.com/7ae5e52d0ab486f41d4b20a134e547ebe2da3769 Cr-Commit-Position: refs/heads/master@{#11532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M webrtc/build/gyp_webrtc View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kjellander_webrtc
Created Revert of Analyze support in gyp_webrtc
4 years, 10 months ago (2016-02-09 06:44:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681023003/1
4 years, 10 months ago (2016-02-09 06:44:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681023003/1
4 years, 10 months ago (2016-02-09 07:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681023003/1
4 years, 10 months ago (2016-02-09 07:31:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 07:46:39 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 07:46:50 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ae5e52d0ab486f41d4b20a134e547ebe2da3769
Cr-Commit-Position: refs/heads/master@{#11532}

Powered by Google App Engine
This is Rietveld 408576698