Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: webrtc/media/webrtc/fakewebrtcvideocapturemodule.h

Issue 1679323002: Cleanup of webrtc::VideoFrame. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Drop return value from FakeWebRtcVideoCaptureModule::SendFrame. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/webrtc/fakewebrtcvideocapturemodule.h
diff --git a/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h b/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h
index 784f2c4f10ebf68e72b9b903e98f016c7c0a57e8..d67e6618f8d90b4d2ddc3fd5be0e5ff0abee67d8 100644
--- a/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h
+++ b/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h
@@ -90,17 +90,14 @@ class FakeWebRtcVideoCaptureModule : public webrtc::VideoCaptureModule {
return 0;
}
- bool SendFrame(int w, int h) {
- if (!running_) return false;
+ void SendFrame(int w, int h) {
+ if (!running_) return;
webrtc::VideoFrame sample;
// Setting stride based on width.
- if (sample.CreateEmptyFrame(w, h, w, (w + 1) / 2, (w + 1) / 2) < 0) {
- return false;
- }
+ sample.CreateEmptyFrame(w, h, w, (w + 1) / 2, (w + 1) / 2);
if (callback_) {
callback_->OnIncomingCapturedFrame(id_, sample);
}
- return true;
}
const webrtc::VideoCaptureCapability& cap() const {

Powered by Google App Engine
This is Rietveld 408576698