webrtc/media/webrtc/fakewebrtcvideocapturemodule.h - Issue 1679323002: Cleanup of webrtc::VideoFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/webrtc/fakewebrtcvideocapturemodule.h

Issue 1679323002: Cleanup of webrtc::VideoFrame. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/webrtc/fakewebrtcvideocapturemodule.h

diff --git a/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h b/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h

index 784f2c4f10ebf68e72b9b903e98f016c7c0a57e8..168a38a3d2107469457f5db4b5e7bf0571f71113 100644

--- a/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h

+++ b/webrtc/media/webrtc/fakewebrtcvideocapturemodule.h

@@ -94,9 +94,7 @@ class FakeWebRtcVideoCaptureModule : public webrtc::VideoCaptureModule {

if (!running_) return false;

webrtc::VideoFrame sample;

// Setting stride based on width.

- if (sample.CreateEmptyFrame(w, h, w, (w + 1) / 2, (w + 1) / 2) < 0) {

- return false;

- }

+ sample.CreateEmptyFrame(w, h, w, (w + 1) / 2, (w + 1) / 2);

if (callback_) {

callback_->OnIncomingCapturedFrame(id_, sample);

}