Switch third_party/gflags to use updated GitHub repo.

Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
NOPRESUBMIT=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv  --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).

Committed: https://crrev.com/4bba35f73517459fa3940034a9b1f8358c14e4ff
Cr-Commit-Position: refs/heads/master@{#11539}

[kjellander_webrtc, 2016-02-09 11:05:26]

Description was changed from

==========
Change gflags to newer, updated repo.

BUG=webrtc:5185
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.

BUG=webrtc:5185
==========

[kjellander_webrtc, 2016-02-09 11:06:17]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-02-09 12:18:44]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-02-09 12:18:48]

Patchset #1 (id:40001) has been deleted

[kjellander_webrtc, 2016-02-09 12:20:24]

Patchset #1 (id:60001) has been deleted

[kjellander_webrtc, 2016-02-09 12:27:26]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.

BUG=webrtc:5185
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
Configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
==========

[kjellander_webrtc, 2016-02-09 12:27:30]

Patchset #1 (id:80001) has been deleted

[kjellander_webrtc, 2016-02-09 12:38:09]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
Configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
Configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
==========

[kjellander_webrtc, 2016-02-09 12:38:09]

kjellander@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kjellander_webrtc, 2016-02-09 13:19:32]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
Configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.

New configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
==========

[kjellander_webrtc, 2016-02-09 14:13:03]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.

New configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.

New configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
NOTRY=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
==========

[kjellander_webrtc, 2016-02-09 14:15:59]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[kjellander_webrtc, 2016-02-09 14:16:08]

kjellander@webrtc.org changed reviewers:
- henrik.lundin@webrtc.org

[kjellander_webrtc, 2016-02-09 14:19:57]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.

New configuration headers were generated on Windows and Linux
and verified they Linux generated ones are working on Mac
(and generating on Mac only differs with an attribute in 
gflags.h that doesn't seem to have any effect).

BUG=webrtc:5185
NOTRY=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
==========

[kjellander_webrtc, 2016-02-09 14:21:07]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).
==========

[kjellander_webrtc, 2016-02-09 14:31:28]

https://codereview.webrtc.org/1679263002/diff/120001/third_party/gflags/gflag...
File third_party/gflags/gflags.gyp (right):

https://codereview.webrtc.org/1679263002/diff/120001/third_party/gflags/gflag...
third_party/gflags/gflags.gyp:31: '<(gflags_gen_arch_root)/include/gflags',  #
For configured files.
The gflags .cc files no longer have any directory in their include paths, so
this had to be updated in order to have them compiling.

https://codereview.webrtc.org/1679263002/diff/120001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc (left):

https://codereview.webrtc.org/1679263002/diff/120001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc:25: #include
"google/gflags.h"
I honestly don't know how this worked before, since the directory was 'gflags'
before as well.

[kjellander_webrtc, 2016-02-09 14:32:15]

See PS#1 and PS#2 for trybot coverage.

[kjellander_webrtc, 2016-02-09 14:34:19]

https://codereview.webrtc.org/1679263002/diff/120001/third_party/gflags/gflag...
File third_party/gflags/gflags.gyp (right):

https://codereview.webrtc.org/1679263002/diff/120001/third_party/gflags/gflag...
third_party/gflags/gflags.gyp:33: '<(gflags_root)/src/src',  # For everything
else.
This is kind of ugly but unavoidable since
https://chromium.googlesource.com/external/github.com/gflags/gflags mirrors the
whole gflags repo (the previous location only mirrored the src subdirectory,
which made it slimmer).

[henrika_webrtc, 2016-02-09 14:39:10]

LGTM

[kjellander_webrtc, 2016-02-09 14:40:28]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-02-09 14:40:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679263002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679263002/140001

[commit-bot: I haz the power, 2016-02-09 14:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 14:42:11]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3322)

[kjellander_webrtc, 2016-02-09 14:47:17]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
NOPRESUBMIT=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).
==========

[kjellander_webrtc, 2016-02-09 14:47:24]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-02-09 14:47:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679263002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679263002/140001

[commit-bot: I haz the power, 2016-02-09 14:47:43]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
NOPRESUBMIT=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
NOPRESUBMIT=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).
==========

[commit-bot: I haz the power, 2016-02-09 14:47:44]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-02-09 14:47:54]

Description was changed from

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
NOPRESUBMIT=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).
==========

to

==========
Switch third_party/gflags to use updated GitHub repo.

This pulls in several fixes and gets Visual Studio 2015 support.
The new repo is located at https://github.com/gflags/gflags
which is mirrored in Chrome infrastructure at
https://chromium.googlesource.com/external/github.com/gflags/gflags

New configuration headers were generated according to README.webrtc
on Windows and Linux. I verified the Linux generated ones are working
on Mac. The generating headers on Mac are identical with only a minor
difference (an __unused attribute) that doesn't effect the build.

BUG=webrtc:5185
NOTRY=True
NOPRESUBMIT=True
TESTED=Successfully ran:
out/Release/video_quality_measurement --input_filename=resources/foreman_cif.yuv
 --width=352 --height=288
to verify flags are still being parsed properly.
I also ran the compile trybots and the baremetal bots
(since they run tests that have gflags flags).

Committed: https://crrev.com/4bba35f73517459fa3940034a9b1f8358c14e4ff
Cr-Commit-Position: refs/heads/master@{#11539}
==========

[commit-bot: I haz the power, 2016-02-09 14:47:55]

Patchset 3 (id:??) landed as
https://crrev.com/4bba35f73517459fa3940034a9b1f8358c14e4ff
Cr-Commit-Position: refs/heads/master@{#11539}