Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 1678773003: Fix div-by-0 in NetEq's StatisticsCalculator (Closed)

Created:
4 years, 10 months ago by hlundin-webrtc
Modified:
4 years, 10 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix div-by-0 in NetEq's StatisticsCalculator If a StatisticsCalculator::PeriodicUmaAverage object was created and then deleted without any samples being logged, the destructor would call the Metric() method, which calculated sum_/counter_. However, with no samples logged, counter_ is 0. This was found and verified using UBSan tests; see the bug for more info. BUG=webrtc:5490 R=ivoc@webrtc.org Committed: https://crrev.com/e594213a2bb6006c41ff1ecc516afc9b024d19ad Cr-Commit-Position: refs/heads/master@{#11534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_coding/neteq/statistics_calculator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
hlundin-webrtc
PTAL
4 years, 10 months ago (2016-02-08 14:26:52 UTC) #1
ivoc
LGTM
4 years, 10 months ago (2016-02-08 14:28:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678773003/1
4 years, 10 months ago (2016-02-08 14:31:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/9701)
4 years, 10 months ago (2016-02-08 15:11:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678773003/1
4 years, 10 months ago (2016-02-08 15:13:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 10 months ago (2016-02-08 16:31:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678773003/1
4 years, 10 months ago (2016-02-09 07:59:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 08:35:58 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 08:36:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e594213a2bb6006c41ff1ecc516afc9b024d19ad
Cr-Commit-Position: refs/heads/master@{#11534}

Powered by Google App Engine
This is Rietveld 408576698