Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1677853002: Remove VideoFormat from WebRtcVideoEngine2. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
noahric, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoFormat from WebRtcVideoEngine2. No longer used since SendStreamFormat has been removed. BUG=webrtc:5332 R=pthatcher@webrtc.org Committed: https://crrev.com/84d1f126d38f2256fb19e59224320563d554d857 Cr-Commit-Position: refs/heads/master@{#11557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M webrtc/media/webrtc/webrtcvideoengine2.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/webrtc/webrtcvideoengine2.cc View 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-06 14:49:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677853002/1
4 years, 10 months ago (2016-02-06 14:49:39 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3279)
4 years, 10 months ago (2016-02-06 14:58:20 UTC) #6
pthatcher1
lgtm
4 years, 10 months ago (2016-02-08 19:17:39 UTC) #7
pbos-webrtc
Committed patchset #1 (id:1) manually as 84d1f126d38f2256fb19e59224320563d554d857 (presubmit successful).
4 years, 10 months ago (2016-02-10 19:13:03 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84d1f126d38f2256fb19e59224320563d554d857 Cr-Commit-Position: refs/heads/master@{#11557}
4 years, 10 months ago (2016-02-10 19:19:03 UTC) #11
noahric
4 years, 10 months ago (2016-02-10 19:37:05 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698