Set use_gtk=0 as default for Chromium builds.

Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

NOTRY=True
BUG=chromium:584722
TBR=tommi@webrtc.org

Committed: https://crrev.com/1c24a6d5ca9613145c4a3a0f6b5f1f39232ba052
Cr-Commit-Position: refs/heads/master@{#11510}

[kjellander_webrtc, 2016-02-05 21:01:19]

Description was changed from

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 is not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

BUG=chromium:584722
TBR=tommi@webrtc.org
==========

to

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

BUG=chromium:584722
TBR=tommi@webrtc.org
==========

[kjellander_webrtc, 2016-02-05 21:01:19]

kjellander@webrtc.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-02-05 21:04:30]

lgtm

https://codereview.webrtc.org/1677693002/diff/1/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/1677693002/diff/1/webrtc/build/common.gypi#newc...
webrtc/build/common.gypi:165: # Chrome OS bots, even if the package is available
in Chromium builds.
nit: I would say 'This is not present in Chrome OS build environments,'

[kjellander_webrtc, 2016-02-05 21:07:29]

Updated the comment, landing.
I'll take care of rolling too.

https://codereview.webrtc.org/1677693002/diff/1/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/1677693002/diff/1/webrtc/build/common.gypi#newc...
webrtc/build/common.gypi:165: # Chrome OS bots, even if the package is available
in Chromium builds.
On 2016/02/05 21:04:30, stevenjb wrote:
> nit: I would say 'This is not present in Chrome OS build environments,'

Done.

[kjellander_webrtc, 2016-02-05 21:07:50]

Description was changed from

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

BUG=chromium:584722
TBR=tommi@webrtc.org
==========

to

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

NOTRY=True
BUG=chromium:584722
TBR=tommi@webrtc.org
==========

[kjellander_webrtc, 2016-02-05 21:07:54]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-02-05 21:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.webrtc.org/1677693002/#ps20001 (title:
"Updated comment")

[commit-bot: I haz the power, 2016-02-05 21:08:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1677693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1677693002/20001

[commit-bot: I haz the power, 2016-02-05 21:10:42]

Description was changed from

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

NOTRY=True
BUG=chromium:584722
TBR=tommi@webrtc.org
==========

to

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

NOTRY=True
BUG=chromium:584722
TBR=tommi@webrtc.org
==========

[commit-bot: I haz the power, 2016-02-05 21:10:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-05 21:10:51]

Description was changed from

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

NOTRY=True
BUG=chromium:584722
TBR=tommi@webrtc.org
==========

to

==========
Set use_gtk=0 as default for Chromium builds.

The files that are built when use_gtk==1 are not included in the Chromium build
(webrtc/media/devices/gtkvideorenderer.cc and
webrtc/media/devices/gtkvideorenderer.h)
so to preserve previous behavior in Chromium before/after
https://codereview.webrtc.org/1587193006, this is the right thing to do.

The reason this was discovered was that a Chrome OS build started failing, since
it was lacking the gtk+2.0 package.

NOTRY=True
BUG=chromium:584722
TBR=tommi@webrtc.org

Committed: https://crrev.com/1c24a6d5ca9613145c4a3a0f6b5f1f39232ba052
Cr-Commit-Position: refs/heads/master@{#11510}
==========

[commit-bot: I haz the power, 2016-02-05 21:10:51]

Patchset 2 (id:??) landed as
https://crrev.com/1c24a6d5ca9613145c4a3a0f6b5f1f39232ba052
Cr-Commit-Position: refs/heads/master@{#11510}

[tommi, 2016-02-05 21:47:53]

lgtm