Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1677333002: Added thread annotations to FifoBuffer. (Closed)

Created:
4 years, 10 months ago by joachim
Modified:
4 years, 10 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added thread annotations to FifoBuffer. This CL adds thread annotations to FifoBuffer and adds a missing CritScope for attribute access that is modified in locked code paths. Committed: https://crrev.com/097d54956dfd2cc3a5983f07a0e35d2c46afac27 Cr-Commit-Position: refs/heads/master@{#11535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M webrtc/base/stream.h View 1 chunk +19 lines, -10 lines 0 comments Download
M webrtc/base/stream.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joachim
Ptal
4 years, 10 months ago (2016-02-08 23:10:45 UTC) #2
tommi
lgtm
4 years, 10 months ago (2016-02-09 08:45:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677333002/1
4 years, 10 months ago (2016-02-09 08:45:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 10:30:38 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 10:30:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/097d54956dfd2cc3a5983f07a0e35d2c46afac27
Cr-Commit-Position: refs/heads/master@{#11535}

Powered by Google App Engine
This is Rietveld 408576698