webrtc/modules/audio_coding/acm2/rent_a_codec.cc - Issue 1677013002: Switch to using new ACM methods for encoder management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/acm2/rent_a_codec.cc

Issue 1677013002: Switch to using new ACM methods for encoder management (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@acm-13

Patch Set: DCHECKs Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_coding/acm2/rent_a_codec.cc

diff --git a/webrtc/modules/audio_coding/acm2/rent_a_codec.cc b/webrtc/modules/audio_coding/acm2/rent_a_codec.cc

index 3bf959e901eab5a297be6256e22e0d2914668242..7f1e52030dc944f9efe244d8fd7f96eec432ebc8 100644

--- a/webrtc/modules/audio_coding/acm2/rent_a_codec.cc

+++ b/webrtc/modules/audio_coding/acm2/rent_a_codec.cc

@@ -263,7 +263,8 @@ RentACodec::StackParameters::~StackParameters() = default;

std::unique_ptr<AudioEncoder> RentACodec::RentEncoderStack(

StackParameters* param) {

- RTC_DCHECK(param->speech_encoder);

+ if (!param->speech_encoder)

+ return nullptr;

if (param->use_codec_fec) {

// Switch FEC on. On failure, remember that FEC is off.

« no previous file with comments | « webrtc/modules/audio_coding/acm2/rent_a_codec.h ('k') | webrtc/modules/audio_coding/acm2/rent_a_codec_unittest.cc » ('j') | no next file with comments »