Switch to using new ACM methods for encoder management

webrtc/modules/audio_coding/acm2/codec_manager.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 37 matching lines @@
     return &codec_stack_params_;
   }
   RentACodec::StackParameters* GetStackParams() { return &codec_stack_params_; }
 
   bool SetCopyRed(bool enable);
 
   bool SetVAD(bool enable, ACMVADMode mode);
 
   bool SetCodecFEC(bool enable_codec_fec);
 
+  // Uses the provided Rent-A-Codec to create a new encoder stack, if we have a
+  // complete specification; if so, it is then passed to set_encoder. On error,
+  // returns false.
+  template <typename F>
+  bool MakeEncoder(RentACodec* rac, F set_encoder) {
+    if (!codec_stack_params_.speech_encoder && send_codec_inst_) {
+      // We have no speech encoder, but we have a specification for making one.
+      auto enc = rac->RentEncoder(*send_codec_inst_);
+      if (!enc)
+        return false;
+      codec_stack_params_.speech_encoder = std::move(enc);
+    }
+    auto stack = rac->RentEncoderStack(&codec_stack_params_);
+    if (stack) {
+      set_encoder(std::move(stack));
+    }
+    return true;

[hlundin-webrtc, 2016/03/29 20:23:32]

If we did not get a stack, we still return true. Does that not count as an
error?

[kwiberg-webrtc, 2016/03/29 23:25:32]

No, because callers may call this method before a speech encoder has been
set—e.g. if CN and RED are registered first.

If the logic seems unduly complex, that’s because it is. What we have currently
(and still have as of this CL) is VoE/libjingle sending configuration data to
the ACM in pieces (such as single CodecInst objects, requests to enable VAD,
etc.), and the ACM must rebuild the encoder stack to the best of its ability
upon receiving each piece. What we hope to get eventually is a complete
specification presented all at once.

[hlundin-webrtc, 2016/03/30 08:36:10]

Acknowledged.

+  }
+
  private:
   rtc::ThreadChecker thread_checker_;
   rtc::Optional<CodecInst> send_codec_inst_;
   RentACodec::StackParameters codec_stack_params_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(CodecManager);
 };
 
 }  // namespace acm2
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_AUDIO_CODING_ACM2_CODEC_MANAGER_H_