Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1677003002: Fix null-pointer dereference in RTPSenderVideo. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix null-pointer dereference in RTPSenderVideo. Since the address of the dereference is taken this inputs a garbage almost-null pointer into RtpPacketizer. Not likely that a load/store is performed on the address, but UBSan fires and it's a source of potential future errors. BUG=webrtc:5124, webrtc:5490 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c0ae305a9ec2652214ca9782be35eb902b81345d

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename video_header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-08 13:46:44 UTC) #1
stefan-webrtc
lgtm https://codereview.webrtc.org/1677003002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right): https://codereview.webrtc.org/1677003002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc#newcode233 webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:233: const RTPVideoHeader* rtpHdr) { Feel free to rename ...
4 years, 10 months ago (2016-02-08 13:58:06 UTC) #4
pbos-webrtc
rename video_header
4 years, 10 months ago (2016-02-08 13:59:30 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c0ae305a9ec2652214ca9782be35eb902b81345d Cr-Commit-Position: refs/heads/master@{#11528}
4 years, 10 months ago (2016-02-08 14:00:26 UTC) #7
pbos-webrtc
4 years, 10 months ago (2016-02-08 14:00:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c0ae305a9ec2652214ca9782be35eb902b81345d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698