Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 167683002: Simplify type argument instantiation cache lookup by introducing an array (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 32709)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -1120,13 +1120,12 @@
const int kInlineInstanceSize = 12; // In words.
const intptr_t instance_size = cls.instance_size();
ASSERT(instance_size > 0);
- Label slow_case_with_type_arguments;
+ if (is_cls_parameterized) {
+ __ movl(EDX, Address(ESP, kObjectTypeArgumentsOffset));
+ // EDX: instantiated type arguments.
+ }
if (FLAG_inline_alloc && Heap::IsAllocatableInNewSpace(instance_size)) {
- Label slow_case_reload_type_arguments;
- if (is_cls_parameterized) {
- __ movl(EDX, Address(ESP, kObjectTypeArgumentsOffset));
- // EDX: instantiated type arguments.
- }
+ Label slow_case;
// Allocate the object and update top to point to
// next object start and initialize the allocated object.
// EDX: instantiated type arguments (if is_cls_parameterized).
@@ -1138,9 +1137,9 @@
// EBX: potential next object start.
__ cmpl(EBX, Address::Absolute(heap->EndAddress()));
if (FLAG_use_slow_path) {
- __ jmp(&slow_case_with_type_arguments);
+ __ jmp(&slow_case);
} else {
- __ j(ABOVE_EQUAL, &slow_case_with_type_arguments);
+ __ j(ABOVE_EQUAL, &slow_case);
}
__ movl(Address::Absolute(heap->TopAddress()), EBX);
__ UpdateAllocationStats(cls.id(), ECX);
@@ -1198,12 +1197,8 @@
__ addl(EAX, Immediate(kHeapObjectTag));
__ ret();
- __ Bind(&slow_case_reload_type_arguments);
+ __ Bind(&slow_case);
}
- if (is_cls_parameterized) {
- __ movl(EDX, Address(ESP, kObjectTypeArgumentsOffset));
- }
- __ Bind(&slow_case_with_type_arguments);
// If is_cls_parameterized:
// EDX: new object type arguments.
// Create a stub frame as we are pushing some objects on the stack before

Powered by Google App Engine
This is Rietveld 408576698