Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1676503002: Remove fake cricket::VideoCapturer devices. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove fake cricket::VideoCapturer devices. Changes rtc_media to depend on rtc_base_approved instead of rtc_base. BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/50fca62809c858686d533d93cd937d41e4791e5f Cr-Commit-Position: refs/heads/master@{#11507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1118 lines) Patch
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/devices/devicemanager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/devices/devicemanager.cc View 4 chunks +3 lines, -52 lines 0 comments Download
M webrtc/media/devices/devicemanager_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D webrtc/media/devices/filevideocapturer.h View 1 chunk +0 lines, -160 lines 0 comments Download
D webrtc/media/devices/filevideocapturer.cc View 1 chunk +0 lines, -385 lines 0 comments Download
D webrtc/media/devices/filevideocapturer_unittest.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D webrtc/media/devices/yuvframescapturer.h View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/media/devices/yuvframescapturer.cc View 1 chunk +0 lines, -199 lines 0 comments Download
M webrtc/media/media.gyp View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/media/media_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
pbos-webrtc
PTAL, these aren't in use and I think they're best moved to whatever project need ...
4 years, 10 months ago (2016-02-05 13:58:30 UTC) #1
pthatcher1
lgtm
4 years, 10 months ago (2016-02-05 16:51:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676503002/1
4 years, 10 months ago (2016-02-05 17:20:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3272)
4 years, 10 months ago (2016-02-05 17:21:48 UTC) #8
pbos-webrtc
Committed patchset #1 (id:1) manually as 50fca62809c858686d533d93cd937d41e4791e5f (presubmit successful).
4 years, 10 months ago (2016-02-05 18:40:49 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50fca62809c858686d533d93cd937d41e4791e5f Cr-Commit-Position: refs/heads/master@{#11507}
4 years, 10 months ago (2016-02-05 18:40:54 UTC) #12
kjellander_webrtc
4 years, 10 months ago (2016-02-08 07:55:00 UTC) #13
Message was sent while issue was closed.
lgtm
sorry I hadn't updated the license headers yet after landing my talk/media move,
but it's done now (https://codereview.webrtc.org/1676923002).

Powered by Google App Engine
This is Rietveld 408576698