Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: webrtc/base/thread.cc

Issue 1675923002: Prevent data race in MessageQueue. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed initialization order. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/messagequeue.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 { 346 {
347 CritScope cs(&crit_); 347 CritScope cs(&crit_);
348 _SendMessage smsg; 348 _SendMessage smsg;
349 smsg.thread = current_thread; 349 smsg.thread = current_thread;
350 smsg.msg = msg; 350 smsg.msg = msg;
351 smsg.ready = &ready; 351 smsg.ready = &ready;
352 sendlist_.push_back(smsg); 352 sendlist_.push_back(smsg);
353 } 353 }
354 354
355 // Wait for a reply 355 // Wait for a reply
356 356 WakeUpSocketServer();
357 ss_->WakeUp();
358 357
359 bool waited = false; 358 bool waited = false;
360 crit_.Enter(); 359 crit_.Enter();
361 while (!ready) { 360 while (!ready) {
362 crit_.Leave(); 361 crit_.Leave();
363 // We need to limit "ReceiveSends" to |this| thread to avoid an arbitrary 362 // We need to limit "ReceiveSends" to |this| thread to avoid an arbitrary
364 // thread invoking calls on the current thread. 363 // thread invoking calls on the current thread.
365 current_thread->ReceiveSendsFromThread(this); 364 current_thread->ReceiveSendsFromThread(this);
366 current_thread->socketserver()->Wait(kForever, false); 365 current_thread->socketserver()->Wait(kForever, false);
367 waited = true; 366 waited = true;
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
534 if (SUCCEEDED(hr)) { 533 if (SUCCEEDED(hr)) {
535 Thread::Run(); 534 Thread::Run();
536 CoUninitialize(); 535 CoUninitialize();
537 } else { 536 } else {
538 LOG(LS_ERROR) << "CoInitialize failed, hr=" << hr; 537 LOG(LS_ERROR) << "CoInitialize failed, hr=" << hr;
539 } 538 }
540 } 539 }
541 #endif 540 #endif
542 541
543 } // namespace rtc 542 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/messagequeue.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698