Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

Issue 1675583002: [rtp_rtcp] rtcp::Tmmbr cleaned and got Parse function (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
index e0c70c2b5cd08a1f5c61581cede0c8df7cbef4f4..4ea4dd8c46f875e4f7f911ada6a5bda777721e98 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
@@ -869,8 +869,7 @@ TEST_F(RtcpReceiverTest, TmmbrPacketAccepted) {
rtcp::Tmmbr tmmbr;
tmmbr.From(kSenderSsrc);
- tmmbr.To(kMediaFlowSsrc);
- tmmbr.WithBitrateKbps(30);
+ tmmbr.WithTmmbr(rtcp::TmmbItem(kMediaFlowSsrc, 30000, 0));
rtcp::SenderReport sr;
sr.From(kSenderSsrc);
@@ -892,8 +891,8 @@ TEST_F(RtcpReceiverTest, TmmbrPacketNotForUsIgnored) {
rtcp::Tmmbr tmmbr;
tmmbr.From(kSenderSsrc);
- tmmbr.To(kMediaFlowSsrc + 1); // This SSRC is not what we are sending.
- tmmbr.WithBitrateKbps(30);
+ // This SSRC is not what we are sending.
+ tmmbr.WithTmmbr(rtcp::TmmbItem(kMediaFlowSsrc + 1, 30000, 0));
rtcp::SenderReport sr;
sr.From(kSenderSsrc);
@@ -916,8 +915,7 @@ TEST_F(RtcpReceiverTest, TmmbrPacketZeroRateIgnored) {
rtcp::Tmmbr tmmbr;
tmmbr.From(kSenderSsrc);
- tmmbr.To(kMediaFlowSsrc);
- tmmbr.WithBitrateKbps(0);
+ tmmbr.WithTmmbr(rtcp::TmmbItem(kMediaFlowSsrc, 0, 0));
rtcp::SenderReport sr;
sr.From(kSenderSsrc);
@@ -940,8 +938,7 @@ TEST_F(RtcpReceiverTest, TmmbrThreeConstraintsTimeOut) {
for (uint32_t ssrc = kSenderSsrc; ssrc < kSenderSsrc + 3; ++ssrc) {
rtcp::Tmmbr tmmbr;
tmmbr.From(ssrc);
- tmmbr.To(kMediaFlowSsrc);
- tmmbr.WithBitrateKbps(30);
+ tmmbr.WithTmmbr(rtcp::TmmbItem(kMediaFlowSsrc, 30000, 0));
rtcp::SenderReport sr;
sr.From(ssrc);

Powered by Google App Engine
This is Rietveld 408576698