Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 1675583002: [rtp_rtcp] rtcp::Tmmbr cleaned and got Parse function (Closed)

Created:
4 years, 10 months ago by danilchap
Modified:
4 years, 10 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] rtcp::Tmmbr cleaned and got Parse function Added accessor and Parse function removed dependencies on structures from rtcp_utility.h (except RtcpCommonHeader) BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/f174e3a2604d6a4dac8a35fbef6145f06f580716 Cr-Commit-Position: refs/heads/master@{#11502}

Patch Set 1 #

Total comments: 4

Patch Set 2 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -123 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h View 2 chunks +25 lines, -27 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc View 1 1 chunk +64 lines, -68 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc View 1 chunk +79 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
danilchap
4 years, 10 months ago (2016-02-05 10:05:27 UTC) #1
åsapersson
lgtm https://codereview.webrtc.org/1675583002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc (right): https://codereview.webrtc.org/1675583002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc#newcode52 webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc:52: << " is too small for a TMBBR."; ...
4 years, 10 months ago (2016-02-05 11:30:18 UTC) #2
danilchap
https://codereview.webrtc.org/1675583002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc (right): https://codereview.webrtc.org/1675583002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc#newcode52 webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc:52: << " is too small for a TMBBR."; On ...
4 years, 10 months ago (2016-02-05 11:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675583002/20001
4 years, 10 months ago (2016-02-05 12:29:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 12:56:39 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 12:56:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f174e3a2604d6a4dac8a35fbef6145f06f580716
Cr-Commit-Position: refs/heads/master@{#11502}

Powered by Google App Engine
This is Rietveld 408576698