Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1675293002: NetEq: Fix a negative shift value (Closed)

Created:
4 years, 10 months ago by hlundin-webrtc
Modified:
4 years, 10 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Fix a negative shift value In some rare occations (very low energy signal), a shift value happened to be negative. This is now fixed by using the WEBRTC_SPL_SHIFT_W32, which in essence checks the sign of the number of shifts and performs a right or left shift accordingly. The fix reverts to how the code was written in old NetEq; see https://chromium.googlesource.com/external/webrtc/+/4d363ae305fa975e7f3ad2a5ca5dbe5e3f101f82/webrtc/modules/audio_coding/neteq/normal.c#165. BUG=webrtc:5490 Committed: https://crrev.com/6608d9a1aa2b67d320aba0193b37271605aa7786 Cr-Commit-Position: refs/heads/master@{#11546}

Patch Set 1 #

Patch Set 2 : Updating checksums for win_x64 #

Patch Set 3 : Updating checksums for android and android64 #

Patch Set 4 : Update neteq4_universal_ref_android.pcm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M resources/audio_coding/neteq4_universal_ref_android.pcm.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 2 2 chunks +20 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/normal.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675293002/1
4 years, 10 months ago (2016-02-08 15:42:09 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/12356)
4 years, 10 months ago (2016-02-08 16:13:24 UTC) #4
hlundin-webrtc
Updating checksums for win_x64
4 years, 10 months ago (2016-02-09 08:20:06 UTC) #5
hlundin-webrtc
Updating checksums for android and android64
4 years, 10 months ago (2016-02-09 09:39:33 UTC) #6
hlundin-webrtc
Update neteq4_universal_ref_android.pcm
4 years, 10 months ago (2016-02-09 13:22:55 UTC) #7
hlundin-webrtc
Ivo, please, take a look.
4 years, 10 months ago (2016-02-09 15:28:24 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675293002/60001
4 years, 10 months ago (2016-02-10 09:23:45 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 10:17:20 UTC) #13
ivoc
LGTM
4 years, 10 months ago (2016-02-10 10:39:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675293002/60001
4 years, 10 months ago (2016-02-10 10:46:41 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-10 10:47:56 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 10:48:01 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6608d9a1aa2b67d320aba0193b37271605aa7786
Cr-Commit-Position: refs/heads/master@{#11546}

Powered by Google App Engine
This is Rietveld 408576698