Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1675143003: Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. (Closed)

Created:
4 years, 10 months ago by hbos
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This is a re-land of https://codereview.webrtc.org/1674103002/. The reason Chromium FYI turned red was due to deps not being relative. See kjellander's CL: https://codereview.webrtc.org/1681493002/. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). Third time's the charm? TBR=kjellander@webrtc.org BUG=chromium:500605, chromium:468365 Committed: https://crrev.com/62756ee41103b72377308a27d7abef0bda878231 Cr-Commit-Position: refs/heads/master@{#11523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M webrtc/build/common.gypi View 1 chunk +14 lines, -10 lines 0 comments Download
M webrtc/build/webrtc.gni View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hbos
If this doesn't work I don't know what; I can compile chrome locally on linux ...
4 years, 10 months ago (2016-02-08 09:58:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675143003/1
4 years, 10 months ago (2016-02-08 09:58:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 10:57:05 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 10:57:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62756ee41103b72377308a27d7abef0bda878231
Cr-Commit-Position: refs/heads/master@{#11523}

Powered by Google App Engine
This is Rietveld 408576698