Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS.

Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. (patchset #1 id:1 of https://codereview.webrtc.org/1674103002/ )

Reason for revert:
Chromium FYI turns red.

Original issue's description:
> Default build flag |rtc_use_h264| to |proprietary_codecs|
> if not on Android/iOS.
>
> This means proprietary_codecs=1 && ffmpeg_branding=Chrome
> can be used to enable this H.264 enc/dec implementation
> instead of rtc_use_h264=1 && ffmpeg_branding=Chrome.
> This is used by both Chromium trybots (but not default
> Chromium build) and offical Chrome build, meaning we will
> be able to test and enable H.264 in chromium.
>
> This change would otherwise be enough to launch this
> feature in Chrome, but because we do not want to do that
> before we have chromium browser tests and are ready to flip
> the switch, this CL prevents chromium from using H.264 just
> yet: https://codereview.chromium.org/1641163002/ (landing
> this after that CL).
>
> Note: This is a re-land of
> https://codereview.webrtc.org/1660403004/. Reverting it
> was not necessary.
>
> TBR=kjellander@webrtc.org
> BUG=chromium:500605, chromium:468365
>
> Committed: https://crrev.com/10b9dd7ab1a8c3f80b2d2924be658e43131a4fbe
> Cr-Commit-Position: refs/heads/master@{#11517}

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:500605, chromium:468365
Committed: https://crrev.com/a81f6a3fc05378faa0e944c6c13d9beece2dac94
Cr-Commit-Position: refs/heads/master@{#11518}

[hbos, 2016-02-07 23:05:12]

Created Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if
not on Android/iOS.

[commit-bot: I haz the power, 2016-02-07 23:05:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1675113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1675113002/1

[commit-bot: I haz the power, 2016-02-07 23:05:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-07 23:05:35]

Description was changed from

==========
Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on
Android/iOS. (patchset #1 id:1 of https://codereview.webrtc.org/1674103002/ )

Reason for revert:
Chromium FYI turns red.

Original issue's description:
> Default build flag |rtc_use_h264| to |proprietary_codecs|
> if not on Android/iOS.
> 
> This means proprietary_codecs=1 && ffmpeg_branding=Chrome
> can be used to enable this H.264 enc/dec implementation
> instead of rtc_use_h264=1 && ffmpeg_branding=Chrome.
> This is used by both Chromium trybots (but not default
> Chromium build) and offical Chrome build, meaning we will
> be able to test and enable H.264 in chromium.
> 
> This change would otherwise be enough to launch this
> feature in Chrome, but because we do not want to do that
> before we have chromium browser tests and are ready to flip
> the switch, this CL prevents chromium from using H.264 just
> yet: https://codereview.chromium.org/1641163002/ (landing
> this after that CL).
> 
> Note: This is a re-land of
> https://codereview.webrtc.org/1660403004/. Reverting it
> was not necessary.
> 
> TBR=kjellander@webrtc.org
> BUG=chromium:500605, chromium:468365
> 
> Committed: https://crrev.com/10b9dd7ab1a8c3f80b2d2924be658e43131a4fbe
> Cr-Commit-Position: refs/heads/master@{#11517}

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:500605, chromium:468365
==========

to

==========
Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on
Android/iOS. (patchset #1 id:1 of https://codereview.webrtc.org/1674103002/ )

Reason for revert:
Chromium FYI turns red.

Original issue's description:
> Default build flag |rtc_use_h264| to |proprietary_codecs|
> if not on Android/iOS.
>
> This means proprietary_codecs=1 && ffmpeg_branding=Chrome
> can be used to enable this H.264 enc/dec implementation
> instead of rtc_use_h264=1 && ffmpeg_branding=Chrome.
> This is used by both Chromium trybots (but not default
> Chromium build) and offical Chrome build, meaning we will
> be able to test and enable H.264 in chromium.
>
> This change would otherwise be enough to launch this
> feature in Chrome, but because we do not want to do that
> before we have chromium browser tests and are ready to flip
> the switch, this CL prevents chromium from using H.264 just
> yet: https://codereview.chromium.org/1641163002/ (landing
> this after that CL).
>
> Note: This is a re-land of
> https://codereview.webrtc.org/1660403004/. Reverting it
> was not necessary.
>
> TBR=kjellander@webrtc.org
> BUG=chromium:500605, chromium:468365
>
> Committed: https://crrev.com/10b9dd7ab1a8c3f80b2d2924be658e43131a4fbe
> Cr-Commit-Position: refs/heads/master@{#11517}

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:500605, chromium:468365

Committed: https://crrev.com/a81f6a3fc05378faa0e944c6c13d9beece2dac94
Cr-Commit-Position: refs/heads/master@{#11518}
==========

[commit-bot: I haz the power, 2016-02-07 23:05:35]

Patchset 1 (id:??) landed as
https://crrev.com/a81f6a3fc05378faa0e944c6c13d9beece2dac94
Cr-Commit-Position: refs/heads/master@{#11518}

[kjellander_webrtc, 2016-02-08 06:47:59]

On 2016/02/07 23:05:35, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/a81f6a3fc05378faa0e944c6c13d9beece2dac94
> Cr-Commit-Position: refs/heads/master@{#11518}

Please include log errors or links to bot logs in the revert message. After a
couple of days it may be hard to find the builds.
I had a look at the errors and the GN error
(https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20GN%20%28dbg%2...)
is simple: WebRTC references needs to be relative, not absolute, in our GN files
in order to be found properly in Chromium.

Similarly for the GYP build
(https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...)
you have to utilize the <(webrtc_root) variable in order for the paths to be
correct in both standalone WebRTC and Chromium builds.
I made a CL to fix this: https://codereview.webrtc.org/1681493002/
With that landed you should be able to reland this again, unless something else
is also broken (please test locally first).

[hbos, 2016-02-08 09:34:47]

On 2016/02/08 06:47:59, kjellander (webrtc) wrote:
> On 2016/02/07 23:05:35, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/a81f6a3fc05378faa0e944c6c13d9beece2dac94
> > Cr-Commit-Position: refs/heads/master@{#11518}
> 
> Please include log errors or links to bot logs in the revert message. After a
> couple of days it may be hard to find the builds.
> I had a look at the errors and the GN error
>
(https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20GN%20%28dbg%2...)
> is simple: WebRTC references needs to be relative, not absolute, in our GN
files
> in order to be found properly in Chromium.
> 
> Similarly for the GYP build
>
(https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...)
> you have to utilize the <(webrtc_root) variable in order for the paths to be
> correct in both standalone WebRTC and Chromium builds.
> I made a CL to fix this: https://codereview.webrtc.org/1681493002/
> With that landed you should be able to reland this again, unless something
else
> is also broken (please test locally first).

Yeah! Sorry for the lack of details, commit-before-bed bad idea.
I'll try to make sure it works locally first, by building a
non-webrtc target in chromium repo that depends on this, I only
tested compiling my webrtc_h264 target in prior CLs which was
fine, perhaps unsurprisingly.