Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1674423002: Enable cpplint for webrtc/modules/pacing and fix all uncovered cpplint errors. (Closed)

Created:
4 years, 10 months ago by joachim
Modified:
4 years, 10 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable cpplint for webrtc/modules/pacing and fix all uncovered cpplint errors. This CL enableds cpplint for webrtc/modules/pacing. BUG=webrtc:5460 NOTRY=true TESTED=Fixed issues reported by: find webrtc/modules/pacing -type f -name *.cc -o -name *.h | xargs cpplint.py followed by 'git cl presubmit'. Committed: https://crrev.com/d2a22960c3283f9eea068f2c3529ec865836bc10 Cr-Commit-Position: refs/heads/master@{#11531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/mock/mock_paced_sender.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/packet_router.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
joachim
Ptal
4 years, 10 months ago (2016-02-08 22:38:25 UTC) #2
mflodman
lgtm And thanks for foxing this!
4 years, 10 months ago (2016-02-09 06:57:12 UTC) #3
mflodman
On 2016/02/09 06:57:12, mflodman wrote: > lgtm > > And thanks for foxing this! ...
4 years, 10 months ago (2016-02-09 06:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674423002/1
4 years, 10 months ago (2016-02-09 07:01:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 07:18:29 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 07:18:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2a22960c3283f9eea068f2c3529ec865836bc10
Cr-Commit-Position: refs/heads/master@{#11531}

Powered by Google App Engine
This is Rietveld 408576698