Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 1673503002: Update build_ios_libs.sh script to build new Objective-C API (Closed)

Created:
4 years, 10 months ago by hjon_webrtc
Modified:
4 years, 10 months ago
Reviewers:
jiayl2, tkchin_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update build_ios_libs.sh script to build new Objective-C API and gather header files. BUG= Committed: https://crrev.com/9bf5cde91a9b1673dcfe22a41ca7df9c000f869b Cr-Commit-Position: refs/heads/master@{#11694}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes based on feedback #

Total comments: 1

Patch Set 3 : Changes based on feedback #

Total comments: 8

Patch Set 4 : Changes based on feedback #

Patch Set 5 : Update against master #

Total comments: 4

Patch Set 6 : Changes based on feedback #

Total comments: 2

Patch Set 7 : Use bool #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -5 lines) Patch
M talk/build/build_ios_libs.sh View 1 2 3 4 5 5 chunks +18 lines, -2 lines 0 comments Download
A talk/build/export_headers View 1 2 3 4 5 6 1 chunk +86 lines, -0 lines 2 comments Download
M talk/build/merge_ios_libs View 1 chunk +4 lines, -2 lines 0 comments Download
M talk/build/merge_ios_libs.gyp View 1 2 3 4 5 1 chunk +9 lines, -1 line 0 comments Download
M talk/build/objc_app.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (9 generated)
hjon_webrtc
4 years, 10 months ago (2016-02-05 01:20:19 UTC) #3
tkchin_webrtc
https://codereview.webrtc.org/1673503002/diff/1/talk/build/build_ios_libs.sh File talk/build/build_ios_libs.sh (right): https://codereview.webrtc.org/1673503002/diff/1/talk/build/build_ios_libs.sh#newcode98 talk/build/build_ios_libs.sh:98: copy_headers ${HEADERS} ${LIBRARY_BASE_DIR}/include Can we do this in a ...
4 years, 10 months ago (2016-02-05 15:57:59 UTC) #4
hjon_webrtc
Changed script to use a list of directories to find header files, as well as ...
4 years, 10 months ago (2016-02-10 21:41:16 UTC) #5
hjon_webrtc
Added the flag we talked about IRL for building the old or new API. Let ...
4 years, 10 months ago (2016-02-16 01:21:53 UTC) #6
tkchin_webrtc
https://codereview.webrtc.org/1673503002/diff/40001/talk/build/export_headers File talk/build/export_headers (right): https://codereview.webrtc.org/1673503002/diff/40001/talk/build/export_headers#newcode20 talk/build/export_headers:20: old_header_dirs = ['talk/app/webrtc/objc/public'] these should be constants, so all ...
4 years, 10 months ago (2016-02-17 22:15:58 UTC) #7
hjon_webrtc
https://codereview.webrtc.org/1673503002/diff/40001/talk/build/export_headers File talk/build/export_headers (right): https://codereview.webrtc.org/1673503002/diff/40001/talk/build/export_headers#newcode20 talk/build/export_headers:20: old_header_dirs = ['talk/app/webrtc/objc/public'] On 2016/02/17 22:15:58, tkchin_webrtc wrote: > ...
4 years, 10 months ago (2016-02-18 19:26:41 UTC) #8
tkchin_webrtc
lgtm % nits https://codereview.webrtc.org/1673503002/diff/80001/talk/build/build_ios_libs.sh File talk/build/build_ios_libs.sh (right): https://codereview.webrtc.org/1673503002/diff/80001/talk/build/build_ios_libs.sh#newcode31 talk/build/build_ios_libs.sh:31: BUILD_NEW_API=0 nit: to be consistent, let's ...
4 years, 10 months ago (2016-02-18 19:32:57 UTC) #9
hjon_webrtc
ptal for confirmation. https://codereview.webrtc.org/1673503002/diff/80001/talk/build/build_ios_libs.sh File talk/build/build_ios_libs.sh (right): https://codereview.webrtc.org/1673503002/diff/80001/talk/build/build_ios_libs.sh#newcode31 talk/build/build_ios_libs.sh:31: BUILD_NEW_API=0 On 2016/02/18 19:32:57, tkchin_webrtc wrote: ...
4 years, 10 months ago (2016-02-18 21:24:00 UTC) #10
tkchin_webrtc
On 2016/02/18 21:24:00, hjon_webrtc wrote: > ptal for confirmation. > > https://codereview.webrtc.org/1673503002/diff/80001/talk/build/build_ios_libs.sh > File talk/build/build_ios_libs.sh ...
4 years, 10 months ago (2016-02-18 23:49:33 UTC) #11
tkchin_webrtc
https://codereview.webrtc.org/1673503002/diff/100001/talk/build/export_headers File talk/build/export_headers (right): https://codereview.webrtc.org/1673503002/diff/100001/talk/build/export_headers#newcode82 talk/build/export_headers:82: use_legacy_headers = args[1] nit: check the string value and ...
4 years, 10 months ago (2016-02-18 23:49:39 UTC) #12
hjon_webrtc
https://codereview.webrtc.org/1673503002/diff/100001/talk/build/export_headers File talk/build/export_headers (right): https://codereview.webrtc.org/1673503002/diff/100001/talk/build/export_headers#newcode82 talk/build/export_headers:82: use_legacy_headers = args[1] On 2016/02/18 23:49:39, tkchin_webrtc wrote: > ...
4 years, 10 months ago (2016-02-19 16:21:31 UTC) #13
tkchin_webrtc
https://codereview.webrtc.org/1673503002/diff/120001/talk/build/export_headers File talk/build/export_headers (right): https://codereview.webrtc.org/1673503002/diff/120001/talk/build/export_headers#newcode82 talk/build/export_headers:82: use_legacy_headers = False if int(args[1]) == 0 else True ...
4 years, 10 months ago (2016-02-19 18:36:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673503002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673503002/120001
4 years, 10 months ago (2016-02-19 19:57:14 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3560)
4 years, 10 months ago (2016-02-19 20:01:09 UTC) #19
hjon_webrtc
@jiayl Could you also take a look?
4 years, 10 months ago (2016-02-19 23:55:54 UTC) #21
jiayl2
lgtm
4 years, 10 months ago (2016-02-20 00:00:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673503002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673503002/120001
4 years, 10 months ago (2016-02-20 00:04:15 UTC) #24
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-02-20 01:15:55 UTC) #26
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 01:16:06 UTC) #28
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/9bf5cde91a9b1673dcfe22a41ca7df9c000f869b
Cr-Commit-Position: refs/heads/master@{#11694}

Powered by Google App Engine
This is Rietveld 408576698