Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1673263002: Update path for audioproc_debug proto output. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update path for audioproc_debug proto output. This will make it align with protoc tools that use the relative path from the project root to the files in the output path. Having this, no hacks will need to be applied downstream. TBR=henrik.lundin@webrtc.org NOTRY=True Committed: https://crrev.com/78ddd733b05c20b0f58216f899f5d07c368647b1 Cr-Commit-Position: refs/heads/master@{#11540}

Patch Set 1 : #

Patch Set 2 : Fix GN build and move the test proto as well #

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-09 09:34:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673263002/40001
4 years, 10 months ago (2016-02-09 16:12:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-09 16:13:13 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/78ddd733b05c20b0f58216f899f5d07c368647b1 Cr-Commit-Position: refs/heads/master@{#11540}
4 years, 10 months ago (2016-02-09 16:13:28 UTC) #10
hlundin-webrtc
4 years, 10 months ago (2016-02-10 09:48:18 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698