Chromium Code Reviews| Index: talk/app/webrtc/java/jni/androidmediaencoder_jni.cc |
| diff --git a/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc b/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc |
| index aade95ba46a4eaad5ad409455accbd7de476dee2..7a115af479b652d72fbb131d99997f2d2d66cbff 100644 |
| --- a/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc |
| +++ b/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc |
| @@ -372,7 +372,6 @@ int32_t MediaCodecVideoEncoder::InitEncode( |
| size_t /* max_payload_size */) { |
| const int kMinWidth = 320; |
| const int kMinHeight = 180; |
| - const int kLowQpThresholdDenominator = 3; |
| if (codec_settings == NULL) { |
| ALOGE << "NULL VideoCodec instance"; |
| return WEBRTC_VIDEO_CODEC_ERR_PARAMETER; |
| @@ -393,16 +392,20 @@ int32_t MediaCodecVideoEncoder::InitEncode( |
| // (internal) range: [0, 127]. And we cannot change QP_max in HW, so it is |
| // always = 127. Note that in SW, QP is that of the user-level range [0, |
| // 63]. |
| - const int kMaxQp = 127; |
| - const int kBadQpThreshold = 95; |
| - quality_scaler_.Init( |
| - kMaxQp / kLowQpThresholdDenominator, kBadQpThreshold, false); |
| + const int kLowQpThreshold = 32; |
| + const int kBadQpThreshold = 92; |
| + quality_scaler_.Init(kLowQpThreshold, kBadQpThreshold, false, |
| + codec_settings->startBitrate, |
| + codec_settings->width, codec_settings->height); |
| } else if (codecType_ == kVideoCodecH264) { |
| // H264 QP is in the range [0, 51]. |
| const int kMaxQp = 51; |
| + const int kLowQpThresholdDenominator = 3; |
|
pbos-webrtc
2016/02/09 20:31:29
Let's just put a constant here without the denomin
AlexG
2016/02/09 23:37:18
Done.
|
| const int kBadQpThreshold = 40; |
| quality_scaler_.Init( |
| - kMaxQp / kLowQpThresholdDenominator, kBadQpThreshold, false); |
| + kMaxQp / kLowQpThresholdDenominator, kBadQpThreshold, false, |
| + codec_settings->startBitrate, |
| + codec_settings->width, codec_settings->height); |
| } else { |
| // When adding codec support to additional hardware codecs, also configure |
| // their QP thresholds for scaling. |