Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1671613004: Made implicit casts in the echo canceller explicit. (Closed)

Created:
4 years, 10 months ago by peah-webrtc
Modified:
4 years, 10 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Made implicit casts in the echo canceller explicit. BUG= Committed: https://crrev.com/48fa27136af4c7cab92134b19fa89a0ec75eec6c Cr-Commit-Position: refs/heads/master@{#11501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webrtc/modules/audio_processing/aec/echo_cancellation.c View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
peah-webrtc
4 years, 10 months ago (2016-02-05 07:15:13 UTC) #2
ivoc
LGTM
4 years, 10 months ago (2016-02-05 09:06:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671613004/1
4 years, 10 months ago (2016-02-05 10:17:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 11:16:23 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 11:16:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/48fa27136af4c7cab92134b19fa89a0ec75eec6c
Cr-Commit-Position: refs/heads/master@{#11501}

Powered by Google App Engine
This is Rietveld 408576698