Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: webrtc/api/peerconnectioninterface_unittest.cc

Issue 1671173002: Track pending ICE restarts independently for different media sections. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Extend ICE restart test to check that a second answer has new credentials. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/peerconnectioninterface_unittest.cc
diff --git a/webrtc/api/peerconnectioninterface_unittest.cc b/webrtc/api/peerconnectioninterface_unittest.cc
index 7178ac3b5c216456104e3483896b345f7a58dafa..7dd45736119f19affa26a2d525e1f4c04e435b64 100644
--- a/webrtc/api/peerconnectioninterface_unittest.cc
+++ b/webrtc/api/peerconnectioninterface_unittest.cc
@@ -2390,14 +2390,15 @@ TEST(CreateSessionOptionsTest, GetDefaultMediaSessionOptionsForOffer) {
RTCOfferAnswerOptions rtc_options;
cricket::MediaSessionOptions options;
+ options.transport_options["audio"] = cricket::TransportOptions();
+ options.transport_options["video"] = cricket::TransportOptions();
EXPECT_TRUE(ConvertRtcOptionsForOffer(rtc_options, &options));
EXPECT_TRUE(options.has_audio());
EXPECT_FALSE(options.has_video());
EXPECT_TRUE(options.bundle_enabled);
EXPECT_TRUE(options.vad_enabled);
- EXPECT_FALSE(options.audio_transport_options.ice_restart);
- EXPECT_FALSE(options.video_transport_options.ice_restart);
- EXPECT_FALSE(options.data_transport_options.ice_restart);
+ EXPECT_FALSE(options.transport_options["audio"].ice_restart);
+ EXPECT_FALSE(options.transport_options["video"].ice_restart);
}
// Test that a correct MediaSessionOptions is created for an offer if
@@ -2438,16 +2439,16 @@ TEST(CreateSessionOptionsTest, GetMediaSessionOptionsForOfferWithIceRestart) {
rtc_options.ice_restart = true;
cricket::MediaSessionOptions options;
+ options.transport_options["audio"] = cricket::TransportOptions();
+ options.transport_options["video"] = cricket::TransportOptions();
EXPECT_TRUE(ConvertRtcOptionsForOffer(rtc_options, &options));
- EXPECT_TRUE(options.audio_transport_options.ice_restart);
- EXPECT_TRUE(options.video_transport_options.ice_restart);
- EXPECT_TRUE(options.data_transport_options.ice_restart);
+ EXPECT_TRUE(options.transport_options["audio"].ice_restart);
+ EXPECT_TRUE(options.transport_options["video"].ice_restart);
rtc_options = RTCOfferAnswerOptions();
EXPECT_TRUE(ConvertRtcOptionsForOffer(rtc_options, &options));
- EXPECT_FALSE(options.audio_transport_options.ice_restart);
- EXPECT_FALSE(options.video_transport_options.ice_restart);
- EXPECT_FALSE(options.data_transport_options.ice_restart);
+ EXPECT_FALSE(options.transport_options["audio"].ice_restart);
+ EXPECT_FALSE(options.transport_options["video"].ice_restart);
}
// Test that the MediaConstraints in an answer don't affect if audio and video

Powered by Google App Engine
This is Rietveld 408576698