Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1670973002: [rtp_rtcp] rtcp::Tmmbn cleaned and got Parse function (Closed)

Created:
4 years, 10 months ago by danilchap
Modified:
4 years, 10 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] rtcp::Tmmbn cleaned and got Parse function Added accessor and Parse function removed dependencies on structures from rtcp_utility.h (except RtcpCommonHeader) removed limitation of 50 items per TMMBN. BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/7336eeb690a87405e6f0e6eaf99e5d3c0c2189b3 Cr-Commit-Position: refs/heads/master@{#11524}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase & spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -140 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h View 2 chunks +26 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc View 1 2 chunks +54 lines, -74 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn_unittest.cc View 1 chunk +78 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danilchap
4 years, 10 months ago (2016-02-05 10:11:54 UTC) #1
åsapersson
lgtm https://codereview.webrtc.org/1670973002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc (right): https://codereview.webrtc.org/1670973002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc#newcode51 webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc:51: << " is too small for TMBBN."; TMBBN->TMMBN ...
4 years, 10 months ago (2016-02-08 10:06:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670973002/20001
4 years, 10 months ago (2016-02-08 10:47:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-08 11:35:16 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 11:35:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7336eeb690a87405e6f0e6eaf99e5d3c0c2189b3
Cr-Commit-Position: refs/heads/master@{#11524}

Powered by Google App Engine
This is Rietveld 408576698