Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1670763005: Use a delayed encoder in GetStats test. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use a delayed encoder in GetStats test. Guarantees seeing non-zero CpuOveruseMetrics stats. BUG= R=stefan@webrtc.org Committed: https://crrev.com/c6e16e3d91d8a02ec5844317e484b8a7ff771072 Cr-Commit-Position: refs/heads/master@{#11504}

Patch Set 1 #

Patch Set 2 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
compile
4 years, 10 months ago (2016-02-05 13:10:34 UTC) #1
stefan-webrtc
lgtm, but please verify that we don't have code that assumes that 0 is invalid/not ...
4 years, 10 months ago (2016-02-05 13:14:12 UTC) #2
pbos-webrtc
Committed patchset #2 (id:20001) manually as c6e16e3d91d8a02ec5844317e484b8a7ff771072 (presubmit successful).
4 years, 10 months ago (2016-02-05 13:16:08 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 13:16:10 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c6e16e3d91d8a02ec5844317e484b8a7ff771072
Cr-Commit-Position: refs/heads/master@{#11504}

Powered by Google App Engine
This is Rietveld 408576698