Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1670153003: Introduce struct MediaConfig, with construction-time settings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed test nit; use reference. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/nullwebrtcvideoengine.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2.h
diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h
index 40485eeb17ef7774e1beda14da53bda0a340a93b..a8218324f8c9297f4030273ed4fc4098be489f75 100644
--- a/webrtc/media/engine/webrtcvideoengine2.h
+++ b/webrtc/media/engine/webrtcvideoengine2.h
@@ -34,6 +34,7 @@
namespace webrtc {
class VideoDecoder;
class VideoEncoder;
+struct MediaConfig;
}
namespace rtc {
@@ -98,6 +99,7 @@ class WebRtcVideoEngine2 {
void Init();
WebRtcVideoChannel2* CreateChannel(webrtc::Call* call,
+ const MediaConfig& config,
const VideoOptions& options);
const std::vector<VideoCodec>& codecs() const;
@@ -130,6 +132,7 @@ class WebRtcVideoChannel2 : public VideoMediaChannel,
public webrtc::LoadObserver {
public:
WebRtcVideoChannel2(webrtc::Call* call,
+ const MediaConfig& config,
const VideoOptions& options,
const std::vector<VideoCodec>& recv_codecs,
WebRtcVideoEncoderFactory* external_encoder_factory,
@@ -137,6 +140,8 @@ class WebRtcVideoChannel2 : public VideoMediaChannel,
~WebRtcVideoChannel2() override;
// VideoMediaChannel implementation
+ rtc::DiffServCodePoint PreferredDscp() const override;
+
bool SetSendParameters(const VideoSendParameters& params) override;
bool SetRecvParameters(const VideoRecvParameters& params) override;
bool GetSendCodec(VideoCodec* send_codec) override;
@@ -479,11 +484,13 @@ class WebRtcVideoChannel2 : public VideoMediaChannel,
DefaultUnsignalledSsrcHandler default_unsignalled_ssrc_handler_;
UnsignalledSsrcHandler* const unsignalled_ssrc_handler_;
+ const bool signal_cpu_adaptation_;
+ const bool disable_prerenderer_smoothing_;
+
// Separate list of set capturers used to signal CPU adaptation. These should
// not be locked while calling methods that take other locks to prevent
// lock-order inversions.
rtc::CriticalSection capturer_crit_;
- bool signal_cpu_adaptation_ GUARDED_BY(capturer_crit_);
std::map<uint32_t, VideoCapturer*> capturers_ GUARDED_BY(capturer_crit_);
rtc::CriticalSection stream_crit_;
« no previous file with comments | « webrtc/media/engine/nullwebrtcvideoengine.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698