Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: webrtc/api/webrtcsession_unittest.cc

Issue 1670153003: Introduce struct MediaConfig, with construction-time settings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed test nit; use reference. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/webrtcsession.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/webrtcsession_unittest.cc
diff --git a/webrtc/api/webrtcsession_unittest.cc b/webrtc/api/webrtcsession_unittest.cc
index 1fe3a815925312c1ecb142bd4ae48a49c090691b..16ce621eb81d5e5c26cae467708a33cf49fadc23 100644
--- a/webrtc/api/webrtcsession_unittest.cc
+++ b/webrtc/api/webrtcsession_unittest.cc
@@ -329,7 +329,8 @@ class WebRtcSessionTest
rtc::Thread::Current())),
fake_call_(webrtc::Call::Config()),
media_controller_(
- webrtc::MediaControllerInterface::Create(rtc::Thread::Current(),
+ webrtc::MediaControllerInterface::Create(cricket::MediaConfig(),
+ rtc::Thread::Current(),
channel_manager_.get())),
tdesc_factory_(new cricket::TransportDescriptionFactory()),
desc_factory_(
@@ -4039,28 +4040,6 @@ TEST_F(WebRtcSessionTest, TestSetRemoteOfferFailIfDtlsDisabledAndNoCrypto) {
offer);
}
-// This test verifies DSCP is properly applied on the media channels.
-TEST_F(WebRtcSessionTest, TestDscpConstraint) {
- constraints_.reset(new FakeConstraints());
- constraints_->AddOptional(
- webrtc::MediaConstraintsInterface::kEnableDscp, true);
- Init();
- SendAudioVideoStream1();
- SessionDescriptionInterface* offer = CreateOffer();
-
- SetLocalDescriptionWithoutError(offer);
-
- video_channel_ = media_engine_->GetVideoChannel(0);
- voice_channel_ = media_engine_->GetVoiceChannel(0);
-
- ASSERT_TRUE(video_channel_ != NULL);
- ASSERT_TRUE(voice_channel_ != NULL);
- const cricket::AudioOptions& audio_options = voice_channel_->options();
- const cricket::VideoOptions& video_options = video_channel_->options();
- EXPECT_EQ(rtc::Optional<bool>(true), audio_options.dscp);
- EXPECT_EQ(rtc::Optional<bool>(true), video_options.dscp);
-}
-
TEST_F(WebRtcSessionTest, TestSuspendBelowMinBitrateConstraint) {
constraints_.reset(new FakeConstraints());
constraints_->AddOptional(
« no previous file with comments | « webrtc/api/webrtcsession.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698