talk/app/webrtc/peerconnectionfactory.h - Issue 1670153003: Introduce struct MediaConfig, with construction-time settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnectionfactory.h

Issue 1670153003: Introduce struct MediaConfig, with construction-time settings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed Per's comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/fakemediacontroller.h ('K') | « talk/app/webrtc/peerconnection.cc ('k') | talk/app/webrtc/peerconnectionfactory.cc » ('j') | talk/app/webrtc/peerconnectioninterface_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/peerconnectionfactory.h

diff --git a/talk/app/webrtc/peerconnectionfactory.h b/talk/app/webrtc/peerconnectionfactory.h

index a38218aebe60c9f8aeadc2eded43118de4361501..c55ea71faffdfa9b91a51b4254ed85db9a4e97d4 100644

--- a/talk/app/webrtc/peerconnectionfactory.h

+++ b/talk/app/webrtc/peerconnectionfactory.h

@@ -87,7 +87,8 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface {

bool StartRtcEventLog(rtc::PlatformFile file) override;

void StopRtcEventLog() override;

- virtual webrtc::MediaControllerInterface* CreateMediaController() const;

+ virtual webrtc::MediaControllerInterface* CreateMediaController(

+ const cricket::MediaConfig &config) const;

virtual rtc::Thread* signaling_thread();

virtual rtc::Thread* worker_thread();

const Options& options() const { return options_; }